Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix serializing nulls for a property of a parameterized type with a nullable upper bound with Protobuf #2561

Merged
merged 4 commits into from
Mar 20, 2024
Merged

Fix serializing nulls for a property of a parameterized type with a nullable upper bound with Protobuf #2561

merged 4 commits into from
Mar 20, 2024

Commits on Feb 3, 2024

  1. Support serializing nulls for a property of a parameterized type with… 

    … a nullable upper bound but break some existing tests

This is done by setting `nullableMode` depending on `serializer.descriptor.isNullable` in `encodeSerializableElement`.

Some common test functions are extracted to `TestFunctions.kt` to eliminate duplicate code.

This breaks some existing tests in `ProtobufCollectionsTest`.
    @ShreckYe
    ShreckYe committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    16fc6de View commit details
    Browse the repository at this point in the history

  2. Fix the bug in the implementation that cause the tests to fail in com… 

    …mit 16fc6de

A common `isMapOrList` function is extracted and the `elementKind` local variables is removed with this function so its value is evaluated only when needed.
    @ShreckYe
    ShreckYe committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    7f046a0 View commit details
    Browse the repository at this point in the history

  3. Slightly improve encodeSerializableElement

    @ShreckYe
    ShreckYe committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    a34a8f5 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2024

  1. Remove some unnecessary braces

    @ShreckYe
    ShreckYe committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    779a81c View commit details
    Browse the repository at this point in the history