Get rid of @ExperimentalUnsignedTypes on our declarations that levera… #1962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge non-experimental unsigned types
Member
Author
|
Also, it seems like it's time to lift experimentality as well, @sandwwraith are you aware of any blockers or open (design) issues for this? |
Member
|
I think we can remove experimentality, I don't remember any problems with them |
Member
Author
|
I'll do it in a separate PR then |
sandwwraith
requested changes
Jun 7, 2022
Member
sandwwraith
left a comment
sandwwraith
left a comment
There was a problem hiding this comment.
We also need to change a bit of documentation here:
formats/json/commonMain/src/kotlinx/serialization/json/internal/StreamingJsonDecoder.kt
Show resolved
Hide resolved
Member
|
Do you plan to change |
sandwwraith
approved these changes
Jun 15, 2022
# Conflicts: # core/commonMain/src/kotlinx/serialization/builtins/BuiltinSerializers.kt # core/commonMain/src/kotlinx/serialization/internal/ValueClasses.kt # formats/json/commonMain/src/kotlinx/serialization/json/internal/Composers.kt # formats/json/commonMain/src/kotlinx/serialization/json/internal/StreamingJsonEncoder.kt # formats/json/commonTest/src/kotlinx/serialization/features/inline/EncodeInlineElementTest.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ge non-experimental unsigned types