-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize EmptySerializersModule #1921
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,7 +43,7 @@ class SerializationMethodInvocationOrderTest { | |
class Out : AbstractEncoder() { | ||
var step = 0 | ||
|
||
override val serializersModule: SerializersModule = EmptySerializersModule | ||
override val serializersModule: SerializersModule = EmptySerializersModule() | ||
|
||
override fun beginStructure(descriptor: SerialDescriptor): CompositeEncoder { | ||
when (step) { | ||
|
@@ -80,29 +80,39 @@ class SerializationMethodInvocationOrderTest { | |
|
||
override fun <T : Any?> encodeSerializableValue(serializer: SerializationStrategy<T>, value: T) { | ||
when (step) { | ||
0, 3 -> { step++; serializer.serialize(this, value); return } | ||
0, 3 -> { | ||
step++; serializer.serialize(this, value); return | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you want to make it multi-line, also split statements instead of using If it's autoformatting, better to revert it There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "Rename signature" for some reason apply formatting all over the place |
||
} | ||
} | ||
fail("@$step: encodeSerializableValue($value)") | ||
} | ||
|
||
override fun encodeString(value: String) { | ||
when (step) { | ||
6 -> if (value == "s1") { step++; return } | ||
6 -> if (value == "s1") { | ||
step++; return | ||
} | ||
} | ||
fail("@$step: encodeString($value)") | ||
} | ||
|
||
override fun encodeInt(value: Int) { | ||
when (step) { | ||
8 -> if (value == 42) { step++; return } | ||
8 -> if (value == 42) { | ||
step++; return | ||
} | ||
} | ||
fail("@$step: decodeInt($value)") | ||
} | ||
|
||
override fun endStructure(descriptor: SerialDescriptor) { | ||
when(step) { | ||
9 -> { checkDataDesc(descriptor); step++; return } | ||
10 -> { checkContainerDesc(descriptor); step++; return } | ||
when (step) { | ||
9 -> { | ||
checkDataDesc(descriptor); step++; return | ||
} | ||
10 -> { | ||
checkContainerDesc(descriptor); step++; return | ||
} | ||
} | ||
fail("@$step: endStructure($descriptor)") | ||
} | ||
|
@@ -115,7 +125,7 @@ class SerializationMethodInvocationOrderTest { | |
class Inp : AbstractDecoder() { | ||
var step = 0 | ||
|
||
override val serializersModule: SerializersModule = EmptySerializersModule | ||
override val serializersModule: SerializersModule = EmptySerializersModule() | ||
|
||
override fun beginStructure(descriptor: SerialDescriptor): CompositeDecoder { | ||
when (step) { | ||
|
@@ -152,29 +162,39 @@ class SerializationMethodInvocationOrderTest { | |
|
||
override fun <T : Any?> decodeSerializableValue(deserializer: DeserializationStrategy<T>): T { | ||
when (step) { | ||
0, 3 -> { step++; return deserializer.deserialize(this) } | ||
0, 3 -> { | ||
step++; return deserializer.deserialize(this) | ||
} | ||
} | ||
fail("@$step: decodeSerializableValue()") | ||
} | ||
|
||
override fun decodeString(): String { | ||
when (step) { | ||
6 -> { step++; return "s1" } | ||
6 -> { | ||
step++; return "s1" | ||
} | ||
} | ||
fail("@$step: decodeString()") | ||
} | ||
|
||
override fun decodeInt(): Int { | ||
when (step) { | ||
8 -> { step++; return 42 } | ||
8 -> { | ||
step++; return 42 | ||
} | ||
} | ||
fail("@$step: decodeInt()") | ||
} | ||
|
||
override fun endStructure(descriptor: SerialDescriptor) { | ||
when(step) { | ||
10 -> { checkDataDesc(descriptor); step++; return } | ||
12 -> { checkContainerDesc(descriptor); step++; return } | ||
when (step) { | ||
10 -> { | ||
checkDataDesc(descriptor); step++; return | ||
} | ||
12 -> { | ||
checkContainerDesc(descriptor); step++; return | ||
} | ||
} | ||
fail("@$step: endStructure($descriptor)") | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably we need to do one or two things:
SerializersModule {}
so it would returnEmptySerializersModule
when appropriateSerializersModule {}
withEmptySerializersModule()
as we have with JsonThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I honestly do not see reasons to do so, this optimization doesn't carry any real value as well as the diagnostic.
Json
is a different beast as it has a non-trivial initialization cost and also prevents any format-level caching.