Skip to content

Fix ByteString annotation detection when ByteArray is nullable #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sandwwraith merged 1 commit into from
Oct 13, 2020
Merged

Fix ByteString annotation detection when ByteArray is nullable #1139

sandwwraith merged 1 commit into from
Oct 13, 2020

Conversation

@twyatt
Copy link
Contributor

@twyatt twyatt commented Oct 13, 2020 •
edited
Loading

Fixes bug where @ByteString annotation is not detected when ByteArray property is marked nullable.
(was an oversight in #898)

Added tests to validate fix.
As expected, tests fail without fix applied.

@twyatt twyatt changed the base branch from master to dev October 13, 2020 07:14
@twyatt twyatt force-pushed the CBOR/NullableByteString branch from 2e71b94 to 0888a66 Compare October 13, 2020 07:36
@twyatt twyatt marked this pull request as ready for review October 13, 2020 07:41
sandwwraith
sandwwraith approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@sandwwraith sandwwraith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@sandwwraith sandwwraith merged commit 317ff19 into Kotlin:dev Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sandwwraith sandwwraith sandwwraith approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@twyatt @sandwwraith