Do not provide default implementation for serializersModule in Abstra… #1089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwwdfsad
force-pushed
the
abstract-encoder-fix-defaults
branch
4 times, most recently
from
9001a1b to
0e6ff1d
Compare
…ctEncoder and AbstractDecoder This default is not reasonable, never wanted and potentially error-prone
qwwdfsad
force-pushed
the
abstract-encoder-fix-defaults
branch
from
0e6ff1d to
9cb8ceb
Compare
sandwwraith
approved these changes
Sep 21, 2020
formats/json/commonTest/src/kotlinx/serialization/UnknownElementIndexTest.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ctEncoder and AbstractDecoder
This default is not reasonable, never wanted and potentially error-prone