Make all serialization exceptions eligible for coroutines exception recovery #1054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandwwraith
reviewed
Sep 9, 2020
| implementation group: 'com.fasterxml.jackson.core', name: 'jackson-databind', version: jackson_version | ||
| implementation group: 'com.fasterxml.jackson.module', name: 'jackson-module-kotlin', version: jackson_version | ||
| implementation group: 'com.fasterxml.jackson.dataformat', name: 'jackson-dataformat-cbor', version: jackson_version | ||
| implementation "org.jetbrains.kotlinx:kotlinx-coroutines-core:$coroutines_version" |
Member
There was a problem hiding this comment.
The protobuf module also has its own ProtobufDecodingException, although it features only message: String? constructor, so it does not require changes. Should we add a test for it too?
…them yet Ignore corresponding tests
Member
|
@elizarov seems your new tests are failing during Gradle build (they're working in IDE though) |
sandwwraith
approved these changes
Sep 10, 2020
sandwwraith
added a commit
to JetBrains/kotlin
that referenced
this pull request
Sep 16, 2020
sandwwraith
added a commit
to JetBrains/kotlin
that referenced
this pull request
Sep 21, 2020
sandwwraith
added a commit
to JetBrains/kotlin
that referenced
this pull request
Oct 2, 2020
(see Kotlin/kotlinx.serialization#1054) (cherry picked from commit eea4ff3)
sandwwraith
added a commit
to JetBrains/kotlin
that referenced
this pull request
Dec 16, 2020
to signature change (see Kotlin/kotlinx.serialization#1054 and commit eea4ff3)
sandwwraith
added a commit
to JetBrains/kotlin
that referenced
this pull request
Dec 19, 2020
to signature change (see Kotlin/kotlinx.serialization#1054 and commit eea4ff3)
sandwwraith
added a commit
to JetBrains/kotlin
that referenced
this pull request
Dec 20, 2020
to signature change (see Kotlin/kotlinx.serialization#1054 and commit eea4ff3) (cherry picked from commit f671c27)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1047