Security comment for unsafe #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no explanation for why "unsafe" is considered "not safe." A developer who is unaware of the implications might not realize that this is related to XSS and currently has no straightforward way of figuring this out. This comment provides: * An explanation of what is happening. * The use of technical terms (XSS) to allow users to search for more relevant information. * Two action items.
|
Hey @vonox7, thanks for the PR. That's a good note, LGTM |
DonRobo
referenced
this pull request
in DonRobo/home-former
Jul 25, 2024
) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.jetbrains.kotlinx:kotlinx-html-jvm](https://togithub.com/Kotlin/kotlinx.html) | `0.10.1` -> `0.11.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>Kotlin/kotlinx.html (org.jetbrains.kotlinx:kotlinx-html-jvm)</summary> ### [`v0.11.0`](https://togithub.com/Kotlin/kotlinx.html/releases/tag/0.11.0) [Compare Source](https://togithub.com/Kotlin/kotlinx.html/compare/0.10.1...0.11.0) #### What's Changed - Add the `crossorigin` attribute to the `<script>` element by [@​lorenzsimon](https://togithub.com/lorenzsimon) in [https://github.com/Kotlin/kotlinx.html/pull/248](https://togithub.com/Kotlin/kotlinx.html/pull/248) - Security comment for unsafe by [@​vonox7](https://togithub.com/vonox7) in [https://github.com/Kotlin/kotlinx.html/pull/245](https://togithub.com/Kotlin/kotlinx.html/pull/245) - add <u></u> tag by [@​EnvyIT](https://togithub.com/EnvyIT) in [https://github.com/Kotlin/kotlinx.html/pull/241](https://togithub.com/Kotlin/kotlinx.html/pull/241) - Converted Repository into a class to force its instantiation in each execution of the generate task by [@​severn-everett](https://togithub.com/severn-everett) in [https://github.com/Kotlin/kotlinx.html/pull/222](https://togithub.com/Kotlin/kotlinx.html/pull/222) - Fix description of samp and add strike tag by [@​MarcinAman](https://togithub.com/MarcinAman) in [https://github.com/Kotlin/kotlinx.html/pull/184](https://togithub.com/Kotlin/kotlinx.html/pull/184) - Update Kotlin version in `README.md` badge by [@​SimonMarquis](https://togithub.com/SimonMarquis) in [https://github.com/Kotlin/kotlinx.html/pull/252](https://togithub.com/Kotlin/kotlinx.html/pull/252) - Add wasmJs target support. by [@​IlyaGulya](https://togithub.com/IlyaGulya) in [https://github.com/Kotlin/kotlinx.html/pull/251](https://togithub.com/Kotlin/kotlinx.html/pull/251) - Added loading attribute to img tag by [@​severn-everett](https://togithub.com/severn-everett) in [https://github.com/Kotlin/kotlinx.html/pull/220](https://togithub.com/Kotlin/kotlinx.html/pull/220) - Provides a short access to document elements by ID via delegated by [@​jonnyzzz](https://togithub.com/jonnyzzz) in [https://github.com/Kotlin/kotlinx.html/pull/126](https://togithub.com/Kotlin/kotlinx.html/pull/126) - Adding full list of HTML entities by [@​severn-everett](https://togithub.com/severn-everett) in [https://github.com/Kotlin/kotlinx.html/pull/209](https://togithub.com/Kotlin/kotlinx.html/pull/209) - fix samp documentation by [@​KotlinIsland](https://togithub.com/KotlinIsland) in [https://github.com/Kotlin/kotlinx.html/pull/172](https://togithub.com/Kotlin/kotlinx.html/pull/172) - Added onmouseenter and onmouseleave attributes by [@​vitek999](https://togithub.com/vitek999) in [https://github.com/Kotlin/kotlinx.html/pull/169](https://togithub.com/Kotlin/kotlinx.html/pull/169) #### New Contributors - [@​lorenzsimon](https://togithub.com/lorenzsimon) made their first contribution in [https://github.com/Kotlin/kotlinx.html/pull/248](https://togithub.com/Kotlin/kotlinx.html/pull/248) - [@​vonox7](https://togithub.com/vonox7) made their first contribution in [https://github.com/Kotlin/kotlinx.html/pull/245](https://togithub.com/Kotlin/kotlinx.html/pull/245) - [@​EnvyIT](https://togithub.com/EnvyIT) made their first contribution in [https://github.com/Kotlin/kotlinx.html/pull/241](https://togithub.com/Kotlin/kotlinx.html/pull/241) - [@​MarcinAman](https://togithub.com/MarcinAman) made their first contribution in [https://github.com/Kotlin/kotlinx.html/pull/184](https://togithub.com/Kotlin/kotlinx.html/pull/184) - [@​SimonMarquis](https://togithub.com/SimonMarquis) made their first contribution in [https://github.com/Kotlin/kotlinx.html/pull/252](https://togithub.com/Kotlin/kotlinx.html/pull/252) - [@​IlyaGulya](https://togithub.com/IlyaGulya) made their first contribution in [https://github.com/Kotlin/kotlinx.html/pull/251](https://togithub.com/Kotlin/kotlinx.html/pull/251) - [@​jonnyzzz](https://togithub.com/jonnyzzz) made their first contribution in [https://github.com/Kotlin/kotlinx.html/pull/126](https://togithub.com/Kotlin/kotlinx.html/pull/126) - [@​KotlinIsland](https://togithub.com/KotlinIsland) made their first contribution in [https://github.com/Kotlin/kotlinx.html/pull/172](https://togithub.com/Kotlin/kotlinx.html/pull/172) - [@​vitek999](https://togithub.com/vitek999) made their first contribution in [https://github.com/Kotlin/kotlinx.html/pull/169](https://togithub.com/Kotlin/kotlinx.html/pull/169) **Full Changelog**: Kotlin/kotlinx.html@0.10.1...0.11.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/DonRobo/home-former). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzguMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no explanation for why "unsafe" is considered "not safe." A developer who is unaware of the implications might not realize that this is related to XSS and currently has no straightforward way of figuring this out.
This comment provides: