Drop exception handler in for tag to reduce bytecode size #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5l
changed the title
|
Seems this change got into the 0.9.0 release without being somehow marked as a breaking change. For us, this has effectively broken error handling in a ktor project. Is this expected? |
|
@languitar, yep, it is. Could you share the case of how exceptions were handled in your project? |
|
What was broken was the integration with kotlinx html provided by ktor themselves. But it seems the vanished method is handled on main already: https://youtrack.jetbrains.com/issue/KTOR-6124/Not-compatible-with-kotlinx-html-0.9.1 Is it intended that breaking changes appear in this project without major version bumps? |
|
Yep, it is before the stable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.