Remove various obsolete code #4196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@e5l, hi! We would like to remove https://github.com/Kotlin/kotlinx.coroutines/blob/master/kotlinx-coroutines-core/jvm/src/scheduling/Deprecated.kt, and given that Ktor 3.0.0 supposedly comes out soon, it looks like this should be okay. Is it okay? Is Ktor 1.x reaching its EOL? |
|
Sure, it would be great if you can make the release or EAP before September |
qwwdfsad
approved these changes
Aug 2, 2024
| * on construction. | ||
| * | ||
| * When running outside the standard dispatchers, these new fields are just dead weight. | ||
| */ | ||
| internal expect abstract class SchedulerTask internal constructor() : Runnable |
There was a problem hiding this comment.
I really appreciate how you drop off improvements and additional commentary when doing the stewardship. Thanks!
kotlinx-coroutines-core/jvm/test/MutexCancellationStressTest.kt
Outdated
Show resolved
Hide resolved
With the Ktor 3.0.0 release, we will no longer be required to support this code.
dkhalanskyjb
force-pushed
the
dk-remove-deprecated-experimentalCoroutineDispatcher
branch
from
d32dfee to
77f91e2
Compare
zuevmaxim
approved these changes
Aug 12, 2024
dkhalanskyjb
deleted the
dk-remove-deprecated-experimentalCoroutineDispatcher
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.