Aligned filtering for JaCoCo reports with Kover reporting #770
Conversation
Added support of filtering by annotations and ancestors to the wrapper of the JaCoCo reporter. Upgraded the minimal and default JaCoCo version to `0.8.13`
shanshin
force-pushed
the
jacoco-filtered
branch
from
cfcd07a to
616314f
Compare
kover-gradle-plugin/src/main/kotlin/kotlinx/kover/gradle/plugin/dsl/KoverVersions.kt
Outdated
Show resolved
Hide resolved
kover-gradle-plugin/src/main/kotlin/kotlinx/kover/gradle/plugin/tools/jacoco/Commons.kt
Show resolved
Hide resolved
kover-gradle-plugin/src/main/kotlin/kotlinx/kover/gradle/plugin/tools/jacoco/Commons.kt
Outdated
Show resolved
Hide resolved
| && filters.excludesAnnotations.isEmpty() | ||
| && filters.excludeInheritedFrom.isEmpty() | ||
| && filters.includesClasses.isEmpty() | ||
| && filters.includesAnnotations.isEmpty() | ||
| && filters.includeInheritedFrom.isEmpty() |
There was a problem hiding this comment.
If all of them empty, toRegex may return null and then we'll exit a function in that case. WDYT?
There was a problem hiding this comment.
I don't see much difference in the approach, toRegex is called only in one place.
There was a problem hiding this comment.
The logic behind my proposal: we're checking only those filters here that are quirked to construct regex-filter. If a set of such filters will change in the future, we may forget to update it both here and in RegexFilter, but if the check will be co-located with RegexFilter construction, then it'll be harder to forget about the update.
But I don't have a strong opinion on that.
There was a problem hiding this comment.
I prefer not to use null as magic value, I added the isEmpty property.
kover-gradle-plugin/src/main/kotlin/kotlinx/kover/gradle/plugin/dsl/KoverVersions.kt
Outdated
Show resolved
Hide resolved
kover-gradle-plugin/src/main/kotlin/kotlinx/kover/gradle/plugin/tools/jacoco/JacocoFiltering.kt
Outdated
Show resolved
Hide resolved
2 participants
Added support of filtering by annotations and ancestors to the wrapper of the JaCoCo reporter.
Upgraded the minimal and default JaCoCo version to
0.8.13