Skip to content

Conversation

@dkhalanskyjb
Copy link
Collaborator

Proposed by @adam-enko

@dkhalanskyjb dkhalanskyjb requested a review from ilya-g October 22, 2025 13:48
@fzhinkin
Copy link
Contributor

Does it actually improve build times (or anything else)?
If there are no arguments why enabling it could be detrimental, then there should be nothing stopping us from enable it :)

@dkhalanskyjb
Copy link
Collaborator Author

Does it actually improve build times (or anything else)?

Notably. git checkout dkhalanskyjb/enable-build-caches; ./gradlew clean check; ./gradlew clean check; git checkout master; ./gradlew clean check; ./gradlew clean check gives me 3 minutes, 2 minutes, 3 minutes, 3 minutes.

@fzhinkin fzhinkin self-requested a review October 22, 2025 16:38
@fzhinkin
Copy link
Contributor

On macOs, build time improvements are even more impressive (6 minutes without build cache, 3 minutes with build cache enabled). Nice!

@dkhalanskyjb
Copy link
Collaborator Author

there should be nothing stopping us from enable it

The main reason would be if the caching mechanism in KGP were broken and failed to get invalidated when changes occurred—which was absolutely the case a few years back at least. I don't know if we consider the issue solved at this point, but we can try and see.

@dkhalanskyjb dkhalanskyjb merged commit 5070925 into master Oct 30, 2025
1 check passed
@dkhalanskyjb dkhalanskyjb deleted the dkhalanskyjb/enable-build-caches branch October 30, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants