Skip to content

Conversation

@lunakoly
Copy link
Member

@lunakoly lunakoly commented Jul 6, 2025

Local functions inside inlines were never expected to work and were allowed in K2 by accident. Until they are explicitly allowed, they should be avoided.

^KT-77986

Local functions inside inlines were never expected to work and were allowed in
K2 by accident. Until they are explicitly allowed, they should be avoided.

^KT-77986
@lunakoly lunakoly requested a review from dkhalanskyjb July 7, 2025 07:55
Copy link
Collaborator

@dkhalanskyjb dkhalanskyjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change makes sense. kotlin-community/k2/dev doesn't need an approval from a maintainer, though. Instead, the release team is responsible for that branch.

@qwwdfsad
Copy link
Member

qwwdfsad commented Jul 7, 2025

Aren't the changes supposed to go into develop and then merged into kotlin-community/k2/dev to avoid branches divergence?

@dkhalanskyjb
Copy link
Collaborator

(NB: kotlinx-datetime only has master) We can do it that way, yes, but it's also okay to put changes directly into k2/dev, and then, when a library upgrades to the new Kotlin that prohibits some behavior, we can introduce the change as part of the upgrade. I don't have a preference here, both are fine by me.

@dkhalanskyjb dkhalanskyjb merged commit 430975e into kotlin-community/k2/dev Jul 7, 2025
1 check failed
@FenstonSingel
Copy link
Contributor

Instead, the release team is responsible for that branch.

Aren't the changes supposed to go into develop [first]?

FTR JiC: kotlinx-datetime is, in fact, the only kotlinx project that is not being maintained as a KUP by either the Release team or the Libraries team; that honor is mine. Unfortunately, it means two things: 1) I'm not extensively privy to the Release team's processes and commitments regarding kotlinx-as-KUPs (nor do I follow them to a tee as a result of that); 2) my current KF/KLE QA workload has pushed most of my KUP maintenance tasks to the backburner either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants