Skip to content

Implement the same ranges for all platforms #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Mar 3, 2025
Merged

Implement the same ranges for all platforms #453

merged 15 commits into from
Mar 3, 2025

Conversation

dkhalanskyjb
Copy link
Collaborator

@dkhalanskyjb dkhalanskyjb commented Oct 31, 2024 •
edited
Loading

Fixes #432

lukellmann
lukellmann reviewed Nov 1, 2024
View reviewed changes
@dkhalanskyjb dkhalanskyjb force-pushed the uniform-ranges branch 4 times, most recently from b7c293c to ae4373e Compare November 5, 2024 12:52
@dkhalanskyjb dkhalanskyjb marked this pull request as ready for review November 5, 2024 12:52
@dkhalanskyjb dkhalanskyjb requested a review from ilya-g November 5, 2024 12:52
@dkhalanskyjb dkhalanskyjb mentioned this pull request Nov 13, 2024
Draft
qurbonzoda
qurbonzoda reviewed Nov 17, 2024
View reviewed changes
qurbonzoda
qurbonzoda reviewed Nov 18, 2024
View reviewed changes
qurbonzoda
qurbonzoda reviewed Nov 18, 2024
View reviewed changes
qurbonzoda
qurbonzoda reviewed Nov 18, 2024
View reviewed changes
ilya-g
ilya-g reviewed Dec 3, 2024
View reviewed changes
@dkhalanskyjb dkhalanskyjb requested a review from ilya-g December 9, 2024 13:26
@dkhalanskyjb dkhalanskyjb mentioned this pull request Dec 10, 2024
Closed
ilya-g
ilya-g reviewed Feb 20, 2025
View reviewed changes
core/commonKotlin/src/Instant.kt Outdated
Comment on lines 126 to 127
epochSeconds < MIN_SECOND -> MIN
epochSeconds > MAX_SECOND -> MAX
Copy link
Member

@ilya-g ilya-g Feb 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it still possible? If the Instant range doesn't potentially fit in the Long range of milliseconds, doesn't it mean that the Long range of milliseconds always fits in the Instant range?

@dkhalanskyjb dkhalanskyjb merged commit 2e197e5 into master Mar 3, 2025
1 check passed
@dkhalanskyjb dkhalanskyjb deleted the uniform-ranges branch March 3, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukellmann lukellmann lukellmann left review comments

@ilya-g ilya-g ilya-g approved these changes

@qurbonzoda qurbonzoda qurbonzoda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make admissible ranges the same on all platforms
4 participants
@dkhalanskyjb @ilya-g @qurbonzoda @lukellmann