Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LocalDateTime arithmetic to the README #126

Merged
merged 2 commits into from
Jun 16, 2021
Merged

Add LocalDateTime arithmetic to the README #126

merged 2 commits into from
Jun 16, 2021

Conversation

dkhalanskyjb
Copy link
Collaborator

Fixes #66

@dkhalanskyjb dkhalanskyjb requested a review from ilya-g June 4, 2021 08:36
ilya-g
ilya-g approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@ilya-g ilya-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this summarizes our view on the missing LocalDateTime arithmetic.

I'd rather say not fixes #66, but closes #66.

README.md Outdated
### Date + time arithmetic

Arithmetic on `LocalDateTime` is intentionally omitted. The reason for this is that the presence of time zone
transitions (like changing from standard time to daylight saving time and back) causes `LocalDateTime` arithmetic to be
Copy link
Member

@ilya-g ilya-g Jun 7, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"time zone transitions" -> "daylight saving time transitions"

@dkhalanskyjb dkhalanskyjb merged commit ff43dd6 into master Jun 16, 2021
@dkhalanskyjb dkhalanskyjb deleted the localdatetime-arithmetic-readme branch June 16, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-g ilya-g ilya-g approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LocalDateTime arithmetic
2 participants
@dkhalanskyjb @ilya-g