-
Notifications
You must be signed in to change notification settings - Fork 43
Add information about analysis notebooks to README and print a link along with results #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@cmelchior could you please help with notebooks: I was going to add yet another notebook that'll compare benchmarks from the same run with each other and stumbled across a problem I can't solve quickly. The JSON file with run results may not contain the For instance, consider plugging such a result file into a notebook: https://gist.githubusercontent.com/fzhinkin/afb9423170056af2696877f837f7950b/raw/31f6bb2e45ba5888f0b78ad7ebb9e62d5be563b0/main.json Maybe you have some good ideas? |
|
Hmm, it can be tricky to support benchmarks with and without params. The reason is that our JSON type generator uses the JSON content it has available to generate types. So if there are no params in the JSON, the I see two solutions to this:
I am leaning towards solution 2 and can add the modification. If you agree? For the example file you had there, I copied a notebook and did minimal adjustments to remove it, trying to parse the params: |
|
@cmelchior, the second option sounds good to me. After all, later all that could be moved to a separate artifacts that notebooks will use as a dependency, I guess.
It seems like it does not work :( |
|
I pushed updates to the example notebooks that should make them work in a generic manner. The key change is using custom serialization classes that uses The serialization classes can be created using |
Left only properties supported by both JMH and kx-benchmark
|
Slightly trimmed the Also, added an example project comparing some "baseline" and "optimized" implementations of the same algorithm, and added a notebook that analyses its results. |
Also, updated notebooks to be more flexible with params.