KT-78372 Disable Klibs cross compilation #540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AYastrebov could you please elaborate why that's necessary? Are there any negative consequences of cross-compiling AFU's native libs? |
Cross compilation with cinterops is only possible on supported host systems. If we find cinterops during the configuration phase, then the ERROR diagnostic will be fired and build will be cancelled. |
|
@fzhinkin can we merge it? It blocks my MR into kotlin repo |
woainikk
approved these changes
Jun 17, 2025
fzhinkin
approved these changes
Jun 17, 2025
fzhinkin
added a commit
that referenced
this pull request
Jun 25, 2025
Follow up for #540. See KT-78372.
fzhinkin
added a commit
that referenced
this pull request
Jun 25, 2025
Follow up for #540. See KT-78372.
fzhinkin
added a commit
that referenced
this pull request
Jun 25, 2025
Follow up for #540. See KT-78372.
fzhinkin
added a commit
that referenced
this pull request
Jun 25, 2025
Follow up for #540. See KT-78372.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Kotlin 2.2.20 we’ve been planning to enable Klibs cross compilation by default. For atomicfu we now need to explicitly disable cross compilation
kotlin.native.enableKlibsCrossCompilation=false