Replace SynchronizedObject reference with kotlin/Any in class Metadata #404
Conversation
…rence with kotlin/Any in class Metadata. See: https://youtrack.jetbrains.com/issue/KT-63413
|
In this PR I've also added a new test: a multi-module project where kotlinx-atomicfu is only applied to one module instead of the root project application. The bug with from the issue was only reproduced with cross-module usage of the class that inherited This test revealed another problem that was fixed here #405, based on the changes from the current PR. |
| override fun checkReferences(buildDir: File) { | ||
| val atomicfuDir = buildDir.resolve("classes/atomicfu/") | ||
| (if (atomicfuDir.exists() && atomicfuDir.isDirectory) atomicfuDir else buildDir).let { | ||
| val atomicfuDirExists = atomicfuDir.exists() && atomicfuDir.isDirectory |
There was a problem hiding this comment.
In tests, we should know for sure how classes were transformed and what directories are expected to be there.
I recommend reducing the amount of conditional logic here and instead explicitly pass a directory and a flag to filter out the metadata from the test.
Otherwise, we may end up in a situation when build directories layout will change, this test won't be update accidentally, and it'll no longer catch the problem with afu-references as it will always filter the metadata.
There was a problem hiding this comment.
Right, this got very complicated. I've separated these cases
|
I've fixed the tests: in case of bytecode transformation we should only check classes in |
See: https://youtrack.jetbrains.com/issue/KT-63413