Skip to content

1.2.2 release #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 1, 2022
Prev Previous commit
Next Next commit
updating gradle, fix scala plugin for 2.12 versions, jackson fix now …
…only for spark 3.3.1
  • Loading branch information
Jolanrensen committed Dec 1, 2022
commit 76e3ea264bf02aa8d4bf561e2c9a843e4cdb0160
16 changes: 11 additions & 5 deletions core/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,10 @@ dependencies {
reflect,
)

// https://github.com/FasterXML/jackson-bom/issues/52
if (Versions.spark == "3.3.1") implementation(jacksonDatabind)

implementation(
jacksonDatabind, // Spark 3.3.1 https://github.com/FasterXML/jackson-bom/issues/52
sparkSql,
)
}
Expand All @@ -36,14 +38,18 @@ dependencies {

java {
toolchain {
languageVersion.set(
JavaLanguageVersion.of(Versions.jvmTarget)
)
if (Versions.scalaCompat.toDouble() > 2.12) { // scala 2.12 will always target java 8
languageVersion.set(
JavaLanguageVersion.of(Versions.jvmTarget)
)
}
}
}

tasks.withType<ScalaCompile> {
targetCompatibility = Versions.jvmTarget
if (Versions.scalaCompat.toDouble() > 2.12) { // scala 2.12 will always target java 8
targetCompatibility = Versions.jvmTarget
}
}

val scalaMainSources = sourceSets.main.get().scala.sourceDirectories
Expand Down
5 changes: 4 additions & 1 deletion examples/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,12 @@ dependencies {
}

with(Dependencies) {

// https://github.com/FasterXML/jackson-bom/issues/52
if (Versions.spark == "3.3.1") implementation(jacksonDatabind)

implementation(
sparkSql,
jacksonDatabind, // Spark 3.3.1 https://github.com/FasterXML/jackson-bom/issues/52
sparkMl,
sparkStreaming,
sparkStreamingKafka,
Expand Down
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.5-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6-bin.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
5 changes: 4 additions & 1 deletion jupyter/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,10 @@ dependencies {
}

with(Dependencies) {

// https://github.com/FasterXML/jackson-bom/issues/52
if (Versions.spark == "3.3.1") implementation(jacksonDatabind)

api(
kotlinxHtml,
sparkSql,
Expand All @@ -52,7 +56,6 @@ dependencies {
)

implementation(
jacksonDatabind, // Spark 3.3.1 https://github.com/FasterXML/jackson-bom/issues/52
kotlinStdLib,
)

Expand Down
5 changes: 4 additions & 1 deletion kotlin-spark-api/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,13 @@ dependencies {
}

with(Dependencies) {

// https://github.com/FasterXML/jackson-bom/issues/52
if (Versions.spark == "3.3.1") implementation(jacksonDatabind)

implementation(
kotlinStdLib,
reflect,
jacksonDatabind, // Spark 3.3.1 https://github.com/FasterXML/jackson-bom/issues/52
sparkSql,
sparkStreaming,
hadoopClient,
Expand Down