[K2] Enable Java tests for symbols #3203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmishenev
force-pushed
the
k2-enable-java-tests
branch
from
a8c9bca to
0ba7189
Compare
Comment on lines
-808
to
+804
| | * @return empty string when [Hash Map](java.util.HashMap.containsKey) doesn't contain value. | ||
| | * @return empty string when [Hash Map][java.util.HashMap.containsKey] doesn't contain value. |
Contributor
There was a problem hiding this comment.
Out of curiosity: did you change it because the k2 tests failed or was it an unrelated fix while passing by?
Contributor
Author
There was a problem hiding this comment.
The former. [Hash Map](java.util.HashMap.containsKey) is an incorrect link.
Contributor
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
yeah, I understand, but it doesn't answer the question :) Does K1 support such incorrect links?
Contributor
Author
There was a problem hiding this comment.
Does K1 support such incorrect links?
Yes, that is why the test was passed.
But IDE and K2 do not support them.
vmishenev
added
the
topic: K2
vmishenev
force-pushed
the
k2-enable-java-tests
branch
from
0ba7189 to
9482fdd
Compare
IgnatBeresnev
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is based on #3202. Otherwise, we will have the flaky tests.
Is is tested by https://github.com/Kotlin/dokka/actions/runs/6486414842