Add sitemaps plugin #2009
Open
Add sitemaps plugin #2009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamildoleglo
suggested changes
Jul 9, 2021
|
|
||
| data class SitemapConfiguration( | ||
| var baseUrl: String? = defaultBaseUrl, | ||
| var relativeOutputLocation: String? = defaultRelativeOutputLocation |
There was a problem hiding this comment.
This can probably be non-null because of the default
| private val maybeConfiguration = configuration<SitemapPlugin, SitemapConfiguration>(context) | ||
|
|
||
| override fun invoke(input: RootPageNode): RootPageNode { | ||
| val baseUrl: String = maybeConfiguration?.baseUrl ?: "".also { |
There was a problem hiding this comment.
You can use maybeConfiguration?.baseUrl ?: run { warn(...) ; it.orEmpty() } which is IMHO a little cleaner, but doesn't really matter that much
| locationResolver: DriResolver, | ||
| baseUrl: String | ||
| ): Set<String> { | ||
| val baseUrlWithSlash = baseUrl.takeIf { it.endsWith("/") || it.isEmpty() } ?: "$baseUrl/" |
There was a problem hiding this comment.
Or just baseUrl.removeSuffix("/") + "/"
Bumps [korte-jvm](https://github.com/korlibs/korte) from 2.0.7 to 2.2.0. - [Release notes](https://github.com/korlibs/korte/releases) - [Commits](https://github.com/korlibs/korte/compare/v2.0.7...v2.2.0) --- updated-dependencies: - dependency-name: com.soywiz.korlibs.korte:korte-jvm dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
vmishenev
force-pushed
the
master
branch
2 times, most recently
from
de135ce
to
4397c96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.