Webhelp #1723
Draft
Webhelp #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * We need to choose something different than `index` since webhelp overrides it | ||
| */ | ||
| override val PAGE_WITH_CHILDREN_SUFFIX: String = "webhelp_index" |
| } | ||
| }.let { content -> | ||
| """<?xml version="1.0" encoding="UTF-8"?> | ||
| <!DOCTYPE product-profile |
There was a problem hiding this comment.
I'd extract this <!DOCTYPE> header (or possibly all hardcoded xmls) to some separate file(s) and load it there (as well as in the ProjectDefinitionAppender)
Comment on lines
+23
to
+31
| override val preprocessors: List<PageTransformer> = | ||
| listOf(RootCreator, TableOfContentPreprocessor(), ProjectDefinitionAppender, ConfigurationAppender) |
There was a problem hiding this comment.
This should be an extension
Comment on lines
+43
to
+79
| code { | ||
| attributes["style"] = "block" | ||
| attributes["lang"] = "kotlin" | ||
| val renderer = WebhelpCodeRenderer(dokkaContext) | ||
| +node.children.joinToString(separator = "") { renderer.buildContentNode(it, pageContext) } | ||
| } |
There was a problem hiding this comment.
Maybe you can reuse the tags/code here. Moreover, I'd make this a preprocessor, converting groups with ContentKind.Symbol to ContentCode
vmishenev
force-pushed
the
master
branch
2 times, most recently
from
de135ce
to
4397c96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.