-
Notifications
You must be signed in to change notification settings - Fork 73
Adding some missing converters #958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ea75149
to
32198f2
Compare
…ions from Short/Byte to others
docs/StardustDocs/topics/convert.md
Outdated
@@ -76,3 +80,21 @@ dataFrameOf("direction")("NORTH", "WEST") | |||
|
|||
<dataFrame src="org.jetbrains.kotlinx.dataframe.samples.api.Modify.convertToEnum.html"/> | |||
<!---END--> | |||
|
|||
And finally, [Value classes](https://kotlinlang.org/docs/inline-classes.html) can be created | |||
and unpacked using `convert`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small note, what do you mean "unpacked"? One can convert IntClass to let's say Double?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll rewrite to clarify it a bit. Yes, you can convert IntClass to Double and back :). Didn't know this before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Fixes #894 and updates some of the convert docs.
Added missing conversions:
Added extra conversion tests