Change default flatten parent-child separator to "_" #920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koperagen
reviewed
Oct 15, 2024
| @@ -9,37 +9,41 @@ import org.jetbrains.kotlinx.dataframe.columns.toColumnSet | |||
| import org.jetbrains.kotlinx.dataframe.impl.api.flattenImpl | |||
| import kotlin.reflect.KProperty | |||
|
|
|||
| public const val FLATTEN_DEFAULT_SEPARATOR: String = "_" | |||
There was a problem hiding this comment.
It makes parameter info popup less informative. I think it's better to have it inlined
There was a problem hiding this comment.
Come on IntelliJ XD. Don't make good coding practices harder
There was a problem hiding this comment.
There was a problem hiding this comment.
Good c: Let's inline it before this issue is fixed?
There was a problem hiding this comment.
yes, a KDoc would also help, but it still doesn't show the value in the popup you show :/
Jolanrensen
force-pushed
the
flatten-separator
branch
from
3a36758 to
fbcb8ff
Compare
|
Generated sources will be updated after merging this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #911
While the discussion of separators in generated accessors is for later, this PR at least fixes the case for flatten.
Given a DataFrame with
df.group.child1anddf.group.child2. CallingflattenwithkeepParentNameForColumnswill introduceflatDf.group_child1andflatDf.group_child2by default now.This makes it a bit easier compared to the previous default with "." which made the flattened column name "group.child1" and the accessor
flatDf`.`group child1`.