[Compiler plugin] Support dataFrameOf(Pair<String, List<T>) #908
Conversation
koperagen
added
the
Compiler plugin
koperagen
force-pushed
the
dataFrameOfPairs
branch
from
abec44c to
3596f05
Compare
|
|
| internal fun FirFunctionCall.loadInterpreter(session: FirSession): Interpreter<*>? { | ||
| if ( | ||
| calleeReference.toResolvedNamedFunctionSymbol()?.callableId == Names.TO && |
There was a problem hiding this comment.
so.. does this mean it fails for dataFrameOf(Pair("name", listOf(1, 2, 3)))?
There was a problem hiding this comment.
It's probably fine, most people will use to anyway, but it might be something we should mention in a doc somewhere, for that one person who's going to be very confused as to why their Pair is not recognized by the plugin if the function only accepts pairs as the type argument.
There was a problem hiding this comment.
Good point. Let's support Pair after i put in place more generic way for handling stdlib functions other than "if". And indeed with such things it's much easier to run into something plugin won't understand. One of the things that can be addressed with custom Checker that will highlight it as warning
|
Generated sources will be updated after merging this PR. |
Change in
buildLetCallis needed because this function has a unique(...) -> DataFrameshape, while most other have some kind ofReceiver.(...) -> DataFramedf.convert { }.with { }->df.convert { }.let { it.with { } as ... }for
(...) -> DataFrameit will bedataFrameOf(pairs)->run { dataFrameOf(pairs) as ... }