Skip to content

Add support for varchar columns in PostgreSQL #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

pbreault
Copy link

Fix for #517

Adds support for varchar columns in the postgresql datasource.

This PR also introduces a test for DataFrame#getSchemaForSqlTable.
Remember to comment out @Ignore on the test class to test it against your local postgresql database.

@zaleslaw
Copy link
Collaborator

zaleslaw commented Nov 27, 2023

Dear @pbreault as I mentioned earlier, the previous type mapping was made in the wrong way and will be totally rewritten in #505 . And this PR fix will be covered there.

But I need to say thank you for testing and quick fix, it's a really important for our library!

@zaleslaw
Copy link
Collaborator

Closed in #505

@zaleslaw zaleslaw closed this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants