Docs update & DynamicDataFrameBuilder #435
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jolanrensen
reviewed
Aug 8, 2023
| import io.kotest.matchers.shouldBe | ||
| import org.junit.Test | ||
|
|
||
| class ConstructorsTests { |
There was a problem hiding this comment.
Could you maybe also add a test with duplicate column names? Since DynamicDataFrameBuilder seems to be able to handle those
koperagen
force-pushed
the
split-doc-update
branch
from
f0d4ba8 to
9a53196
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DynamicDataFrameBuilder here is a composition of name generator and mutable list. Useful for Kandy because they create dataframes from columns and need to know column names.
Also changed split documentation and made couple of small changes in other places, so i'd recommend to see commits one by one after #434 is merged (this contains commits from that PR)