-
Notifications
You must be signed in to change notification settings - Fork 73
Add support for swing tables integration in IDEA plugin #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
15ca36d
Add support for swing tables integration in IDEA plugin
ermolenkodev be83d45
Extract functions used by IDEA plugin to utility class
ermolenkodev f37b513
Change MIME type of serialized dataframe
ermolenkodev dcffd2d
Increase min kernel version
ermolenkodev 7ddeab1
Make KotlinNotebookPluginUtils an object instead of a class
ermolenkodev 0371330
Add tests for KotlinNotbookPluginUtils
ermolenkodev 2b2fefa
Revert MIN_KERNEL_VERSION to 0.11.0.198
ermolenkodev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/jupyter/DisableRowsLimitWrapper.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
package org.jetbrains.kotlinx.dataframe.jupyter | ||
|
||
import org.jetbrains.kotlinx.dataframe.AnyFrame | ||
|
||
/** | ||
* Allows for disabling the rows limit when generating a DISPLAY output in Jupyter. | ||
*/ | ||
public data class DisableRowsLimitWrapper(public val value: AnyFrame) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/jupyter/KotlinNotebookPluginUtils.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
package org.jetbrains.kotlinx.dataframe.jupyter | ||
|
||
import org.jetbrains.kotlinx.dataframe.AnyFrame | ||
import org.jetbrains.kotlinx.dataframe.api.filter | ||
|
||
/** | ||
* A class with utility methods for Kotlin Notebook Plugin integration. | ||
* Kotlin Notebook Plugin is acts as a client of Kotlin Jupyter kernel and use this functionality | ||
* for dynamic pagination when rendering dataframes. | ||
* The plugin sends Kotlin following code to the kernel to evaluate | ||
* DISPLAY(KotlinNotebooksPluginUtils.getRowsSubsetForRendering(Out[x], 0, 20), "") | ||
*/ | ||
public object KotlinNotebookPluginUtils { | ||
/** | ||
* Returns a subset of rows from the given dataframe for rendering. | ||
* It's used for example for dynamic pagination in Kotlin Notebook Plugin. | ||
*/ | ||
public fun getRowsSubsetForRendering( | ||
dataFrameLike: Any?, | ||
startIdx: Int, | ||
endIdx: Int | ||
): DisableRowsLimitWrapper = when (dataFrameLike) { | ||
null -> throw IllegalArgumentException("Dataframe is null") | ||
else -> getRowsSubsetForRendering(convertToDataFrame(dataFrameLike), startIdx, endIdx) | ||
} | ||
|
||
/** | ||
* Returns a subset of rows from the given dataframe for rendering. | ||
* It's used for example for dynamic pagination in Kotlin Notebook Plugin. | ||
*/ | ||
public fun getRowsSubsetForRendering(df: AnyFrame, startIdx: Int, endIdx: Int): DisableRowsLimitWrapper = | ||
DisableRowsLimitWrapper(df.filter { it.index() in startIdx until endIdx }) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.