Skip to content

Remove unused useDarkColorScheme parameter from DisplayConfiguration #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Remove unused useDarkColorScheme parameter from DisplayConfiguration #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/io/html.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,6 @@ internal fun HtmlData.print() = println(this)
internal fun initHtml(
includeJs: Boolean = true,
includeCss: Boolean = true,
useDarkColorScheme: Boolean = false,
): HtmlData =
HtmlData(
style = if (includeCss) getResources("/table.css") else "",
Expand Down Expand Up @@ -217,7 +216,6 @@ public data class DisplayConfiguration(
var decimalFormat: RendererDecimalFormat = RendererDecimalFormat.DEFAULT,
var isolatedOutputs: Boolean = flagFromEnv("LETS_PLOT_HTML_ISOLATED_FRAME"),
internal val localTesting: Boolean = flagFromEnv("KOTLIN_DATAFRAME_LOCAL_TESTING"),
var useDarkColorScheme: Boolean = false,
) {
public companion object {
public val DEFAULT: DisplayConfiguration = DisplayConfiguration()
Expand Down
5 changes: 0 additions & 5 deletions core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/jupyter/Integration.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ import org.jetbrains.kotlinx.jupyter.api.KotlinKernelHost
import org.jetbrains.kotlinx.jupyter.api.Notebook
import org.jetbrains.kotlinx.jupyter.api.VariableName
import org.jetbrains.kotlinx.jupyter.api.declare
import org.jetbrains.kotlinx.jupyter.api.libraries.ColorScheme
import org.jetbrains.kotlinx.jupyter.api.libraries.JupyterIntegration
import org.jetbrains.kotlinx.jupyter.api.libraries.resources
import org.jetbrains.kotlinx.jupyter.api.renderHtmlAsIFrameIfNeeded
Expand Down Expand Up @@ -251,10 +250,6 @@ internal class Integration(
// that should not be shown to user in Jupyter variables view
internalTypes.any { property.returnType.isSubtypeOf(it) }
}

onColorSchemeChange {
config.display.useDarkColorScheme = (it == ColorScheme.DARK)
}
}
}

Expand Down
1 change: 0 additions & 1 deletion core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/jupyter/JupyterHtmlRenderer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ internal inline fun <reified T : Any> JupyterHtmlRenderer.render(
extraHtml = initHtml(
includeJs = reifiedDisplayConfiguration.isolatedOutputs,
includeCss = true,
useDarkColorScheme = reifiedDisplayConfiguration.useDarkColorScheme
),
contextRenderer
) { footer }
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/resources/table.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
--link-hover: #1a466c;
}

:root[theme="dark"], :root [data-jp-theme-light="false"], .dataframe_dark{
:root[theme="dark"], :root [data-jp-theme-light="false"] {
--background: #303030;
--background-odd: #3c3c3c;
--background-hover: #464646;
Expand Down