-
Notifications
You must be signed in to change notification settings - Fork 73
Excel add new sheet without overwriting the file #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
10f5c4f
- Added test for new sheet implementation
LeandroC89 27c6396
- Removed unnecessary logging from new sheet test
LeandroC89 a5f8a1b
- Added addSheet functionality (keepFile parameter)
LeandroC89 679d7ff
- Added new function in org.jetbrains.kotlinx.dataframe.samples.api.…
LeandroC89 9182ad6
- Fixed variable use in added function for documentation
LeandroC89 b45557a
- Changed writeExcel location to temporary file
LeandroC89 3d740c2
Merge branch 'master' into ExcelWriteNewSheet
LeandroC89 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove this overload. I think i wanted to create an alias for
() -> Workbook
so that people could call this function likedf.writeExcel(os, ..., WorkbookFactory.XLSX)
, andWorkbookFactory.XLSX
here is a class owned by the dataframe. But i shelved the idea, so this overload adds no value compared to the one belowThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking back at it, should it be renamed to workBook now? Since it is what is really getting passed after this change. I can change it if so.