Skip to content

Remove redundant type parameter from transpose #1553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove redundant type parameter from transpose #1553

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/transpose.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package org.jetbrains.kotlinx.dataframe.api
import org.jetbrains.kotlinx.dataframe.AnyRow
import org.jetbrains.kotlinx.dataframe.DataColumn
import org.jetbrains.kotlinx.dataframe.DataFrame
import org.jetbrains.kotlinx.dataframe.DataRow
import org.jetbrains.kotlinx.dataframe.impl.api.convertTo
import org.jetbrains.kotlinx.dataframe.impl.columnName
import org.jetbrains.kotlinx.dataframe.impl.owner
Expand All @@ -13,7 +12,7 @@ import kotlin.reflect.typeOf

// region DataRow

public fun <T> DataRow<T>.transpose(): DataFrame<NameValuePair<*>> {
public fun AnyRow.transpose(): DataFrame<NameValuePair<*>> {
Copy link
Collaborator

@Jolanrensen Jolanrensen Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this is a binary change or not, otherwise please deprecate the old one as ERROR :) (or HIDDEN even)

val valueColumn = DataColumn.createByInference(NameValuePair<*>::value.columnName, values)
val nameColumn = owner.columnNames().toValueColumn(NameValuePair<*>::name.name)
return dataFrameOf(nameColumn, valueColumn).cast()
Expand Down
Loading