Kotlin 2.2 #1286
Kotlin 2.2 #1286
Conversation
Jolanrensen
added
the
infrastructure
Jolanrensen
force-pushed
the
kotlin-2.2
branch
6 times, most recently
from
8b5f085 to
5d92e20
Compare
| @@ -21,6 +22,7 @@ abstract class KeywordsGeneratorAction : WorkAction<KeywordsGeneratorAction.Para | |||
| private val taskPackageName = "org.jetbrains.kotlinx.dataframe.keywords" | |||
|
|
|||
| override fun execute() { | |||
| println("Generating keywords using Kotlin compiler: ${KotlinCompilerVersion.getVersion()}") | |||
There was a problem hiding this comment.
println? Is it a debug stuff?
There was a problem hiding this comment.
Yes, but I think it's helpful enough. It only runs during the build and it can help us detect whether we've updated our keywords generator version
| dependsOn(*generationTasks.toTypedArray()) | ||
| } | ||
| tasks.withType(KspAATask::class.java).configureEach { | ||
| error( |
There was a problem hiding this comment.
Maybe log.error will be enough?
There was a problem hiding this comment.
Maybe, but in my experience, if KspAATask runs, you get very unhelpful class cast exceptions somewhere during the build process. It's hard to then scroll back to find this specific error log and figure out that is causing the class cast exception.
So, if KspAATask runs, the user cannot have ksp.useKSP2=false, and thus the dataframe plugin will fail at some point anyway. Better to let it fail early with a helpful error message :)
Fixes #995