Skip to content

Add a common interface for exceptions that should be reported by the plugin #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions core/api/core.api
Original file line number Diff line number Diff line change
Expand Up @@ -5459,7 +5459,7 @@ public final class org/jetbrains/kotlinx/dataframe/exceptions/CellConversionExce
public final fun getRow ()Ljava/lang/Integer;
}

public final class org/jetbrains/kotlinx/dataframe/exceptions/ColumnNotFoundException : java/lang/RuntimeException {
public final class org/jetbrains/kotlinx/dataframe/exceptions/ColumnNotFoundException : java/lang/RuntimeException, org/jetbrains/kotlinx/dataframe/exceptions/DataFrameException {
public fun <init> (Ljava/lang/String;Ljava/lang/String;)V
public final fun getColumnName ()Ljava/lang/String;
public fun getMessage ()Ljava/lang/String;
Expand All @@ -5470,7 +5470,11 @@ public final class org/jetbrains/kotlinx/dataframe/exceptions/ColumnTypeMismatch
public final fun getColumn ()Lorg/jetbrains/kotlinx/dataframe/DataColumn;
}

public final class org/jetbrains/kotlinx/dataframe/exceptions/DuplicateColumnNamesException : java/lang/IllegalArgumentException {
public abstract interface class org/jetbrains/kotlinx/dataframe/exceptions/DataFrameException {
public abstract fun getMessage ()Ljava/lang/String;
}

public final class org/jetbrains/kotlinx/dataframe/exceptions/DuplicateColumnNamesException : java/lang/IllegalArgumentException, org/jetbrains/kotlinx/dataframe/exceptions/DataFrameException {
public fun <init> (Ljava/util/List;)V
public final fun getAllColumnNames ()Ljava/util/List;
public final fun getDuplicatedNames ()Ljava/util/List;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
package org.jetbrains.kotlinx.dataframe.exceptions

public class ColumnNotFoundException(public val columnName: String, public override val message: String) :
RuntimeException()
RuntimeException(),
DataFrameException
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
package org.jetbrains.kotlinx.dataframe.exceptions

/**
* If DataFrame function used by compiler plugin as implementation detail throws this exception, [message] will be reported as warning
*/
public interface DataFrameException {
public val message: String
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package org.jetbrains.kotlinx.dataframe.exceptions

public class DuplicateColumnNamesException(public val allColumnNames: List<String>) : IllegalArgumentException() {
public class DuplicateColumnNamesException(public val allColumnNames: List<String>) :
IllegalArgumentException(),
DataFrameException {

public val duplicatedNames: List<String> = allColumnNames
.groupBy { it }
Expand Down