Skip to content

Overhaul for std #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 9, 2025
Merged

Overhaul for std #1119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
96d3c83
started std rework
Jolanrensen Apr 4, 2025
bacf736
moved nullability to generic type parameter for mean/sum for correct …
Jolanrensen Apr 7, 2025
edbcaea
small overhaul for std
Jolanrensen Apr 7, 2025
27ee90e
reverting behavior of rowXOf functions to follow the type of the valu…
Jolanrensen Apr 7, 2025
c9f090b
moved BasicStats.std
Jolanrensen Apr 7, 2025
1646c79
expanded std tests
Jolanrensen Apr 7, 2025
2ee94de
renamed skipNaN_default->skipNaNDefault and ddof_default->ddofDefault
Jolanrensen Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions core/api/core.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1895,8 +1895,8 @@ public abstract interface class org/jetbrains/kotlinx/dataframe/api/DataSchemaEn
}

public final class org/jetbrains/kotlinx/dataframe/api/DefaultsKt {
public static final fun getDdof_default ()I
public static final fun getSkipNaN_default ()Z
public static final fun getDdofDefault ()I
public static final fun getSkipNaNDefault ()Z
}

public final class org/jetbrains/kotlinx/dataframe/api/DescribeKt {
Expand Down Expand Up @@ -4131,11 +4131,13 @@ public final class org/jetbrains/kotlinx/dataframe/api/SumKt {
public static synthetic fun sumFor$default (Lorg/jetbrains/kotlinx/dataframe/api/PivotGroupBy;[Lorg/jetbrains/kotlinx/dataframe/columns/ColumnReference;ZZILjava/lang/Object;)Lorg/jetbrains/kotlinx/dataframe/DataFrame;
public static final synthetic fun sumNumber (Lorg/jetbrains/kotlinx/dataframe/DataColumn;)Ljava/lang/Number;
public static final fun sumNumber (Lorg/jetbrains/kotlinx/dataframe/DataColumn;Z)Ljava/lang/Number;
public static final fun sumNumber (Lorg/jetbrains/kotlinx/dataframe/DataFrame;ZLkotlin/jvm/functions/Function2;)Ljava/lang/Number;
public static final fun sumNumber (Lorg/jetbrains/kotlinx/dataframe/DataFrame;Z[Lkotlin/reflect/KProperty;)Ljava/lang/Number;
public static final fun sumNumber (Lorg/jetbrains/kotlinx/dataframe/DataFrame;[Lorg/jetbrains/kotlinx/dataframe/columns/ColumnReference;Z)Ljava/lang/Number;
public static synthetic fun sumNumber$default (Lorg/jetbrains/kotlinx/dataframe/DataColumn;ZILjava/lang/Object;)Ljava/lang/Number;
public static final fun sumOfByte (Lorg/jetbrains/kotlinx/dataframe/DataColumn;Lkotlin/jvm/functions/Function1;)I
public static final fun sumOfByte (Lorg/jetbrains/kotlinx/dataframe/DataFrame;Lkotlin/jvm/functions/Function2;)I
public static final fun sumOfShort (Lorg/jetbrains/kotlinx/dataframe/DataColumn;Lkotlin/jvm/functions/Function1;)I
public static final fun sumOfShort (Lorg/jetbrains/kotlinx/dataframe/DataFrame;Lkotlin/jvm/functions/Function2;)I
public static synthetic fun sumNumber$default (Lorg/jetbrains/kotlinx/dataframe/DataFrame;ZLkotlin/jvm/functions/Function2;ILjava/lang/Object;)Ljava/lang/Number;
public static synthetic fun sumNumber$default (Lorg/jetbrains/kotlinx/dataframe/DataFrame;Z[Lkotlin/reflect/KProperty;ILjava/lang/Object;)Ljava/lang/Number;
public static synthetic fun sumNumber$default (Lorg/jetbrains/kotlinx/dataframe/DataFrame;[Lorg/jetbrains/kotlinx/dataframe/columns/ColumnReference;ZILjava/lang/Object;)Ljava/lang/Number;
public static final fun sumShort (Lorg/jetbrains/kotlinx/dataframe/DataColumn;)I
public static final fun sumShort (Lorg/jetbrains/kotlinx/dataframe/DataFrame;Lkotlin/jvm/functions/Function2;)I
public static final fun sumShort (Lorg/jetbrains/kotlinx/dataframe/DataFrame;[Lkotlin/reflect/KProperty;)I
Expand Down Expand Up @@ -6446,8 +6448,7 @@ public final class org/jetbrains/kotlinx/dataframe/math/PercentileKt {
}

public final class org/jetbrains/kotlinx/dataframe/math/StdKt {
public static final fun std (Ljava/lang/Iterable;Lkotlin/reflect/KType;ZI)D
public static synthetic fun std$default (Ljava/lang/Iterable;Lkotlin/reflect/KType;ZIILjava/lang/Object;)D
public static final fun std (Lkotlin/sequences/Sequence;Lkotlin/reflect/KType;ZI)D
}

public final class org/jetbrains/kotlinx/dataframe/math/SumKt {
Expand Down
15 changes: 13 additions & 2 deletions core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/Defaults.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,18 @@
package org.jetbrains.kotlinx.dataframe.api

@PublishedApi
internal val skipNaN_default: Boolean = false
internal val skipNaNDefault: Boolean = false

/**
* Default delta degrees of freedom for the standard deviation (std).
*
* The default is set to `1`,
* meaning DataFrame uses [Bessel’s correction](https://en.wikipedia.org/wiki/Bessel%27s_correction) to calculate the
* "unbiased sample standard deviation" by default.
* This is also the standard in languages like R.
*
* This is different from the "population standard deviation" (where `ddof = 0`),
* which is used in libraries like Numpy.
*/
@PublishedApi
internal val ddof_default: Int = 1
internal val ddofDefault: Int = 1
Loading