Add @CandidateForRemoval annotation #1032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koperagen
force-pushed
the
candidate-for-removal
branch
2 times, most recently
from
c58096a to
cc307f1
Compare
Jolanrensen
approved these changes
Jan 28, 2025
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/annotations/CandidateForRemoval.kt
Outdated
Show resolved
Hide resolved
| @@ -20,8 +21,10 @@ import kotlin.experimental.ExperimentalTypeInference | |||
| import kotlin.reflect.KProperty | |||
| import kotlin.reflect.KType | |||
|
|
|||
| @CandidateForRemoval | |||
| public fun AnyRow.isEmpty(): Boolean = owner.columns().all { it[index] == null } | |||
There was a problem hiding this comment.
could be moved to internal maybe? it's used at least once
| @@ -166,12 +169,16 @@ public fun AnyRow.columnNames(): List<String> = df().columnNames() | |||
|
|
|||
| public fun AnyRow.columnTypes(): List<KType> = df().columnTypes() | |||
|
|
|||
| @CandidateForRemoval | |||
There was a problem hiding this comment.
I think these ones should just be documented and better tested. It's in the same family of functions as relative which is powerful in the add DSL. And to populate a column with values using, for instance getRow(0).someCol as part of the calculation seems quite critical. Again, we just need more examples. Though, marking them as CandidateForRemoval is a good way for us to start looking into it again later :)
koperagen
force-pushed
the
candidate-for-removal
branch
from
cc307f1 to
633bc9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1028
For
DataRow.isEmptyandDataRow.isNotEmptyis hard to imagine situation where it'd be usedDataFrame.copyis uselessDataRow.getRows()is a short cut that can be easily replaced, and also hard to imagine a usecase