Skip to content

Support Kotlin Multiplatform Plugin for JVM only #645

Closed
@mgroth0

Description

@mgroth0

There is already an issue for supporting multiplatform. This is issue is a (possibly) much smaller and simpler request. I am requesting support for gradle modules that are jvm-only, but still use the kotlin multiplatform gradle plugin instead of the regular kotlin("jvm") gradle plugin.

I am just getting started with kotlin dataframes so I don't yet know what degree of support there is, if any, already for the using dataframes in a multiplatform project that only defines a jvm target. However, I can say that upon trying I right away received a warning that indicated to me that there may not be support for this type of project setup:

The 'ksp' configuration is deprecated in Kotlin Multiplatform projects. Please use target-specific configurations like 'kspJvm' instead.

In the best case scenario, maybe kotlin dataframes already mostly supports the kotlin multiplatform plugin and this is just an issue where dataframes needs to make a small change to respect this warning. If that is true, here is my suggestion:

In ConvenienceSchemaGeneratorPlugin in the line that does target.configurations.getByName("ksp").dependencies.add, add add a check for if the kotlin multiplatform plugin is applied. If it is, just use the configuration "kspJvm" instead. And then further down, use "kspJvmTest" instead of "kspTest".

Best case scenario, its just a few lines of code. I could do the PR myself, but if someone more familiar with this project wants to please go ahead as I'm still getting my first look at it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions