-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve test suite with more use cases #40
Merged
qwwdfsad
merged 1 commit into
Kotlin:master
from
joffrey-bion:jbion/tests-for-subprojects
Feb 1, 2021
Merged
Improve test suite with more use cases #40
qwwdfsad
merged 1 commit into
Kotlin:master
from
joffrey-bion:jbion/tests-for-subprojects
Feb 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here are some of the new tests: * tests that api file name matches custom project name (settings.gradle) * tests that check tasks runs apiCheck * tests projects hierarchies with plugin applied to root project
joffrey-bion
force-pushed
the
jbion/tests-for-subprojects
branch
from
January 27, 2021 19:07
a79b37a
to
f5b997c
Compare
joffrey-bion
commented
Jan 27, 2021
src/functionalTest/kotlin/kotlinx/validation/test/IgnoredClassesTests.kt
Show resolved
Hide resolved
joffrey-bion
commented
Jan 27, 2021
src/functionalTest/kotlin/kotlinx/validation/test/IgnoredClassesTests.kt
Show resolved
Hide resolved
joffrey-bion
commented
Jan 27, 2021
src/functionalTest/kotlin/kotlinx/validation/api/BaseKotlinGradleTest.kt
Show resolved
Hide resolved
qwwdfsad
approved these changes
Feb 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Thanks for such a valuable contribution, it will definitely help all the future contributors and maintainers 👍
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Oct 28, 2024
Here are some of the new tests: * tests that api file name matches custom project name (settings.gradle) * tests that check tasks runs apiCheck * tests projects hierarchies with plugin applied to root project Pull request Kotlin/binary-compatibility-validator#40
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Dec 3, 2024
Here are some of the new tests: * tests that api file name matches custom project name (settings.gradle) * tests that check tasks runs apiCheck * tests projects hierarchies with plugin applied to root project Pull request Kotlin/binary-compatibility-validator#40
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Dec 13, 2024
Here are some of the new tests: * tests that api file name matches custom project name (settings.gradle) * tests that check tasks runs apiCheck * tests projects hierarchies with plugin applied to root project Pull request Kotlin/binary-compatibility-validator#40
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Dec 23, 2024
Here are some of the new tests: * tests that api file name matches custom project name (settings.gradle) * tests that check tasks runs apiCheck * tests projects hierarchies with plugin applied to root project Pull request Kotlin/binary-compatibility-validator#40 Moved from Kotlin/binary-compatibility-validator@3ed63f9
KotlinBuild
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Jan 3, 2025
Here are some of the new tests: * tests that api file name matches custom project name (settings.gradle) * tests that check tasks runs apiCheck * tests projects hierarchies with plugin applied to root project Pull request Kotlin/binary-compatibility-validator#40 Moved from Kotlin/binary-compatibility-validator@3ed63f9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some of the new tests:
check
task runsapiCheck
To do this, I added some facilities to create nested directories via the test DSL.
Also, I added helpers to create api files in the test DSL, thus avoiding the implicit creation of api file by
@Before
in the parent test class (some tests need the api file to be absent, or to be initialized with some content).