Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test suite with more use cases #40

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

joffrey-bion
Copy link
Contributor

@joffrey-bion joffrey-bion commented Jan 27, 2021

Here are some of the new tests:

  • tests that api file name matches custom project name (settings.gradle)
  • tests that check task runs apiCheck
  • tests including project hierarchies with plugin applied to root project

To do this, I added some facilities to create nested directories via the test DSL.
Also, I added helpers to create api files in the test DSL, thus avoiding the implicit creation of api file by @Before in the parent test class (some tests need the api file to be absent, or to be initialized with some content).

Here are some of the new tests:

* tests that api file name matches custom project name (settings.gradle)
* tests that check tasks runs apiCheck
* tests projects hierarchies with plugin applied to root project
@qwwdfsad qwwdfsad self-requested a review February 1, 2021 10:09
Copy link
Collaborator

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Thanks for such a valuable contribution, it will definitely help all the future contributors and maintainers 👍

@qwwdfsad qwwdfsad merged commit 3ed63f9 into Kotlin:master Feb 1, 2021
@joffrey-bion joffrey-bion deleted the jbion/tests-for-subprojects branch February 1, 2021 15:07
shanshin pushed a commit to JetBrains/kotlin that referenced this pull request Oct 28, 2024
Here are some of the new tests:

* tests that api file name matches custom project name (settings.gradle)
* tests that check tasks runs apiCheck
* tests projects hierarchies with plugin applied to root project
Pull request Kotlin/binary-compatibility-validator#40
shanshin pushed a commit to JetBrains/kotlin that referenced this pull request Dec 3, 2024
Here are some of the new tests:

* tests that api file name matches custom project name (settings.gradle)
* tests that check tasks runs apiCheck
* tests projects hierarchies with plugin applied to root project
Pull request Kotlin/binary-compatibility-validator#40
shanshin pushed a commit to JetBrains/kotlin that referenced this pull request Dec 13, 2024
Here are some of the new tests:

* tests that api file name matches custom project name (settings.gradle)
* tests that check tasks runs apiCheck
* tests projects hierarchies with plugin applied to root project
Pull request Kotlin/binary-compatibility-validator#40
shanshin pushed a commit to JetBrains/kotlin that referenced this pull request Dec 23, 2024
Here are some of the new tests:

* tests that api file name matches custom project name (settings.gradle)
* tests that check tasks runs apiCheck
* tests projects hierarchies with plugin applied to root project
Pull request Kotlin/binary-compatibility-validator#40

Moved from Kotlin/binary-compatibility-validator@3ed63f9
KotlinBuild pushed a commit to JetBrains/kotlin that referenced this pull request Jan 3, 2025
Here are some of the new tests:

* tests that api file name matches custom project name (settings.gradle)
* tests that check tasks runs apiCheck
* tests projects hierarchies with plugin applied to root project
Pull request Kotlin/binary-compatibility-validator#40

Moved from Kotlin/binary-compatibility-validator@3ed63f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants