Skip to content

Make Klib-related Gradle tasks public #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Jun 24, 2024
Merged

Make Klib-related Gradle tasks public #204

merged 26 commits into from
Jun 24, 2024

Conversation

fzhinkin
Copy link
Collaborator

@fzhinkin fzhinkin commented Mar 26, 2024 •
edited
Loading

What was done:

  • cleaned up klib-related tasks API
  • rewrote code gluing up tasks together to utilize Gradle properties for proper dependency tracking
  • made tasks public
  • made some programmatic API classes used as tasks inputs serializable

Fixed #203

@fzhinkin fzhinkin force-pushed the make-tasks-public branch from e94154b to bb48561 Compare March 27, 2024 09:13
@fzhinkin fzhinkin added enhancement New feature or request klib labels Mar 27, 2024
@fzhinkin fzhinkin linked an issue Mar 27, 2024 that may be closed by this pull request
Make KLib validation related tasks public #203
Closed
@fzhinkin fzhinkin marked this pull request as ready for review March 27, 2024 09:20
@fzhinkin fzhinkin requested a review from shanshin March 27, 2024 09:20
Base automatically changed from 199-disable-tasks-for-empty-projects to develop March 27, 2024 14:36
@fzhinkin fzhinkin force-pushed the make-tasks-public branch from bb48561 to 25efc08 Compare March 27, 2024 14:40
@fzhinkin fzhinkin mentioned this pull request Mar 28, 2024
Closed
@fzhinkin fzhinkin force-pushed the make-tasks-public branch from 25efc08 to 5a03695 Compare April 5, 2024 10:36
@fzhinkin fzhinkin mentioned this pull request Apr 25, 2024
Merged
shanshin
shanshin reviewed May 13, 2024
View reviewed changes
@fzhinkin fzhinkin mentioned this pull request Jun 5, 2024
Merged
@fzhinkin fzhinkin force-pushed the make-tasks-public branch from 2b7b900 to 4de527a Compare June 6, 2024 10:18
@fzhinkin fzhinkin requested a review from shanshin June 11, 2024 12:51
@fzhinkin fzhinkin force-pushed the make-tasks-public branch from 8b0f562 to d8271ab Compare June 21, 2024 11:32
@fzhinkin fzhinkin requested a review from shanshin June 21, 2024 13:56
shanshin
shanshin approved these changes Jun 21, 2024
View reviewed changes
src/main/kotlin/BuildTaskBase.kt
import org.gradle.api.tasks.Input
import org.gradle.api.tasks.Internal
import org.gradle.api.tasks.OutputFile
import java.io.File


public abstract class BuildTaskBase : DefaultTask() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we link a public task so tightly to a specific extension?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tasks are tightly bound to BCV anyway. The thing that worries me more is implicit initialization of properties, but I'm not sure that making initialization explicit and moving it to BinaryCompatibilityValidatorPlugin will make a big difference for now

@fzhinkin fzhinkin mentioned this pull request Jun 24, 2024
Closed
@fzhinkin fzhinkin merged commit ee129a1 into develop Jun 24, 2024
3 checks passed
@fzhinkin fzhinkin deleted the make-tasks-public branch June 24, 2024 12:43
shanshin pushed a commit to JetBrains/kotlin that referenced this pull request Oct 28, 2024
@fzhinkin @shanshin
[ABI Validation] Make Klib-related Gradle tasks public
1e26d07 
Fixes Kotlin/binary-compatibility-validator#203 
Pull request Kotlin/binary-compatibility-validator#204
shanshin pushed a commit to JetBrains/kotlin that referenced this pull request Dec 3, 2024
@fzhinkin @shanshin
[ABI Validation] Make Klib-related Gradle tasks public
7e13208 
Fixes Kotlin/binary-compatibility-validator#203 
Pull request Kotlin/binary-compatibility-validator#204
shanshin pushed a commit to JetBrains/kotlin that referenced this pull request Dec 13, 2024
@fzhinkin @shanshin
[ABI Validation] Make Klib-related Gradle tasks public
dcc0907 
Fixes Kotlin/binary-compatibility-validator#203 
Pull request Kotlin/binary-compatibility-validator#204
shanshin pushed a commit to JetBrains/kotlin that referenced this pull request Dec 23, 2024
@fzhinkin @shanshin
[ABI Validation] Make Klib-related Gradle tasks public
b4285de 
Fixes Kotlin/binary-compatibility-validator#203 
Pull request Kotlin/binary-compatibility-validator#204

Moved from Kotlin/binary-compatibility-validator@ee129a1
KotlinBuild pushed a commit to JetBrains/kotlin that referenced this pull request Jan 3, 2025
@fzhinkin
[ABI Validation] Make Klib-related Gradle tasks public
9bc87fe 
Fixes Kotlin/binary-compatibility-validator#203 
Pull request Kotlin/binary-compatibility-validator#204

Moved from Kotlin/binary-compatibility-validator@ee129a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanshin shanshin shanshin approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request klib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make KLib validation related tasks public
2 participants
@fzhinkin @shanshin