Correctly handle compilations without sources #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzhinkin
commented
Mar 22, 2024
fzhinkin
force-pushed
the
199-disable-tasks-for-empty-projects
branch
from
1d933c4 to
ac77421
Compare
shanshin
reviewed
Mar 26, 2024
src/functionalTest/kotlin/kotlinx/validation/test/KlibVerificationTests.kt
Show resolved
Hide resolved
JakeWharton
reviewed
Mar 26, 2024
shanshin
approved these changes
Mar 27, 2024
fzhinkin
added a commit
that referenced
this pull request
Apr 3, 2024
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Oct 28, 2024
* Correctly handle targets with a main compilation resulting in no compiled artifacts * Postpone source directories check by wrapping it into a provider Fixes Kotlin/binary-compatibility-validator#199 Pull request Kotlin/binary-compatibility-validator#200
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Oct 28, 2024
…otlin/binary-compatibility-validator#200 * Rollback task skipping logic based on srcset emptyness check for JVM tasks Pull request Kotlin/binary-compatibility-validator#212
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Dec 3, 2024
* Correctly handle targets with a main compilation resulting in no compiled artifacts * Postpone source directories check by wrapping it into a provider Fixes Kotlin/binary-compatibility-validator#199 Pull request Kotlin/binary-compatibility-validator#200
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Dec 3, 2024
…otlin/binary-compatibility-validator#200 * Rollback task skipping logic based on srcset emptyness check for JVM tasks Pull request Kotlin/binary-compatibility-validator#212
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Dec 13, 2024
* Correctly handle targets with a main compilation resulting in no compiled artifacts * Postpone source directories check by wrapping it into a provider Fixes Kotlin/binary-compatibility-validator#199 Pull request Kotlin/binary-compatibility-validator#200
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Dec 13, 2024
…otlin/binary-compatibility-validator#200 * Rollback task skipping logic based on srcset emptyness check for JVM tasks Pull request Kotlin/binary-compatibility-validator#212
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Dec 23, 2024
* Correctly handle targets with a main compilation resulting in no compiled artifacts * Postpone source directories check by wrapping it into a provider Fixes Kotlin/binary-compatibility-validator#199 Pull request Kotlin/binary-compatibility-validator#200 Moved from Kotlin/binary-compatibility-validator@e478dd6
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Dec 23, 2024
…otlin/binary-compatibility-validator#200 * Rollback task skipping logic based on srcset emptyness check for JVM tasks Pull request Kotlin/binary-compatibility-validator#212 Moved from Kotlin/binary-compatibility-validator@4de530a
KotlinBuild
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Jan 3, 2025
* Correctly handle targets with a main compilation resulting in no compiled artifacts * Postpone source directories check by wrapping it into a provider Fixes Kotlin/binary-compatibility-validator#199 Pull request Kotlin/binary-compatibility-validator#200 Moved from Kotlin/binary-compatibility-validator@e478dd6
KotlinBuild
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Jan 3, 2025
…otlin/binary-compatibility-validator#200 * Rollback task skipping logic based on srcset emptyness check for JVM tasks Pull request Kotlin/binary-compatibility-validator#212 Moved from Kotlin/binary-compatibility-validator@4de530a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BCV's Klib-validation part does not handle compilations without any sources properly, as a result tasks manipulating dumps might expect a dump for a target that doesn't have any compiled klibs.
Such targets/compilations occur when, for example, a project consists only of test sources.
Verified the fix locally using both projects mentioned in the original bug report.
Fixes #199