Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements #101

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Minor improvements #101

merged 2 commits into from
Oct 20, 2022

Conversation

ilya-g
Copy link
Member

@ilya-g ilya-g commented Oct 20, 2022

  • make Project.sourceSets internal
  • use correct path delimiter in error message

@ilya-g ilya-g requested a review from qwwdfsad October 20, 2022 14:03
qwwdfsad
qwwdfsad approved these changes Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@qwwdfsad qwwdfsad merged commit 89c1b22 into master Oct 20, 2022
@qwwdfsad qwwdfsad deleted the minor-improve branch October 20, 2022 14:18
@ilya-g
Copy link
Member Author

ilya-g commented Oct 20, 2022

Good, Let's release 0.12 with these changes

shanshin pushed a commit to JetBrains/kotlin that referenced this pull request Oct 28, 2024
@ilya-g @shanshin
[ABI Validation] Minor improvements
4b2505e 
* Use the correct path delimiter in error messages
* Make Project.sourceSets helper internal and migrate from deprecated convention
Pull request Kotlin/binary-compatibility-validator#101
shanshin pushed a commit to JetBrains/kotlin that referenced this pull request Dec 3, 2024
@ilya-g @shanshin
[ABI Validation] Minor improvements
40c2c39 
* Use the correct path delimiter in error messages
* Make Project.sourceSets helper internal and migrate from deprecated convention
Pull request Kotlin/binary-compatibility-validator#101
shanshin pushed a commit to JetBrains/kotlin that referenced this pull request Dec 13, 2024
@ilya-g @shanshin
[ABI Validation] Minor improvements
8010563 
* Use the correct path delimiter in error messages
* Make Project.sourceSets helper internal and migrate from deprecated convention
Pull request Kotlin/binary-compatibility-validator#101
shanshin pushed a commit to JetBrains/kotlin that referenced this pull request Dec 23, 2024
@ilya-g @shanshin
[ABI Validation] Minor improvements
d9914e2 
* Use the correct path delimiter in error messages
* Make Project.sourceSets helper internal and migrate from deprecated convention
Pull request Kotlin/binary-compatibility-validator#101

Moved from Kotlin/binary-compatibility-validator@89c1b22
KotlinBuild pushed a commit to JetBrains/kotlin that referenced this pull request Jan 3, 2025
@ilya-g
[ABI Validation] Minor improvements
59118c0 
* Use the correct path delimiter in error messages
* Make Project.sourceSets helper internal and migrate from deprecated convention
Pull request Kotlin/binary-compatibility-validator#101

Moved from Kotlin/binary-compatibility-validator@89c1b22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwwdfsad qwwdfsad qwwdfsad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilya-g @qwwdfsad