Lesson 4. Task 1 #184

Stupidman00 · 2016-10-24T06:21:12Z

Использование глобальных переменных - это плохой стиль. Какие варианты решения данной проблемы есть в этом задании?

…on sequenceDigit()

kotlin-polytech-bot · 2016-10-24T06:22:09Z

author

Stupidman00 [bva1138@yandex.ru]

lesson1.task1

Author: Stupidman00 [bva1138@yandex.ru]

Owner: Stupidman00 []

Total: 12 / 12

Example: 4 / 4
Trivial: 4 / 4
Easy: 4 / 4

Succeeded:

[Trivial] lesson1.task1/seconds
[Trivial] lesson1.task1/lengthInMeters
[Easy] lesson1.task1/travelMinutes
[Trivial] lesson1.task1/angleInRadian
[Easy] lesson1.task1/thirdDigit
[Example] lesson1.task1/sqr
[Example] lesson1.task1/discriminant
[Example] lesson1.task1/sqRoot
[Trivial] lesson1.task1/trackLength
[Example] lesson1.task1/quadraticRootProduct
[Easy] lesson1.task1/accountInThreeYears
[Easy] lesson1.task1/numberRevert

Seed: -6267269258667053021

lesson4.task1

Author: Stupidman00 [bva1138@yandex.ru]

Owner: Stupidman00 []

Total: 20 / 21

Example: 7 / 7
Easy: 2 / 2
Normal: 7 / 7
Hard: 4 / 4
Impossible: 0 / 1

Succeeded:

[Normal] lesson4.task1/convert
[Example] lesson4.task1/sqRoots
[Example] lesson4.task1/biRoots
[Example] lesson4.task1/negativeList
[Example] lesson4.task1/invertPositives
[Example] lesson4.task1/squares
[Example] lesson4.task1/isPalindrome
[Example] lesson4.task1/buildSumExample
[Easy] lesson4.task1/mean
[Normal] lesson4.task1/center
[Normal] lesson4.task1/times
[Normal] lesson4.task1/polynom
[Normal] lesson4.task1/accumulate
[Normal] lesson4.task1/factorize
[Hard] lesson4.task1/factorizeToString
[Hard] lesson4.task1/convertToString
[Normal] lesson4.task1/decimal
[Hard] lesson4.task1/decimalFromString
[Hard] lesson4.task1/roman
[Easy] lesson4.task1/abs

Failed:

[Impossible] lesson4.task1/russian
- Expected:
  двести пятьдесят одна тысяча девятьсот шестьдесят восемь
- Actual:
  двести пятьдесят одна тысяч девятьсот шестьдесят восемь
- Inputs:
  - n ->
    251968
- Exception: null

Seed: -6267269258667053021

owner

Stupidman00 []

Stupidman00 · 2016-10-24T08:45:26Z

Ошибку нашел. Понимаю как решить.

mglukhikh · 2016-10-25T12:28:09Z

Надеюсь, сегодня на лекции я ответил на ваш вопрос про глобальные переменные

mglukhikh · 2016-10-25T12:30:39Z

recheck all

kotlin-polytech-bot · 2016-10-25T12:32:03Z

author

Stupidman00 [bva1138@yandex.ru]

lesson1.task1

Author: Stupidman00 [bva1138@yandex.ru]

Owner: Stupidman00 []

Total: 12 / 12

Example: 4 / 4
Trivial: 4 / 4
Easy: 4 / 4

Succeeded:

[Trivial] lesson1.task1/seconds
[Example] lesson1.task1/sqRoot
[Example] lesson1.task1/discriminant
[Trivial] lesson1.task1/angleInRadian
[Easy] lesson1.task1/travelMinutes
[Easy] lesson1.task1/numberRevert
[Example] lesson1.task1/sqr
[Trivial] lesson1.task1/lengthInMeters
[Trivial] lesson1.task1/trackLength
[Example] lesson1.task1/quadraticRootProduct
[Easy] lesson1.task1/thirdDigit
[Easy] lesson1.task1/accountInThreeYears

Seed: 4944206926986033707

lesson2.task1

Author: Stupidman00 [bva1138@yandex.ru]

Owner: Stupidman00 []

Total: 7 / 7

Example: 1 / 1
Easy: 5 / 5
Normal: 1 / 1

Succeeded:

[Easy] lesson2.task1/whichRookThreatens
[Example] lesson2.task1/minBiRoot
[Easy] lesson2.task1/ageDescription
[Easy] lesson2.task1/timeForHalfWay
[Easy] lesson2.task1/rookOrBishopThreatens
[Easy] lesson2.task1/triangleKind
[Normal] lesson2.task1/segmentLength

Seed: 4944206926986033707

lesson2.task2

Author: Stupidman00 [bva1138@yandex.ru]

Owner: Stupidman00 []

Total: 5 / 5

Example: 1 / 1
Easy: 2 / 2
Normal: 2 / 2

Succeeded:

[Example] lesson2.task2/pointInsideCircle
[Easy] lesson2.task2/isNumberHappy
[Easy] lesson2.task2/queenThreatens
[Normal] lesson2.task2/circleInside
[Normal] lesson2.task2/brickPasses

Seed: 4944206926986033707

lesson3.task1

Author: Stupidman00 [bva1138@yandex.ru]

Owner: Stupidman00 []

Total: 18 / 18

Example: 4 / 4
Trivial: 1 / 1
Easy: 8 / 8
Normal: 3 / 3
Hard: 2 / 2

Succeeded:

[Example] lesson3.task1/factorial
[Example] lesson3.task1/isPrime
[Example] lesson3.task1/isPerfect
[Example] lesson3.task1/digitCountInNumber
[Trivial] lesson3.task1/digitNumber
[Easy] lesson3.task1/lcm
[Easy] lesson3.task1/minDivisor
[Easy] lesson3.task1/maxDivisor
[Easy] lesson3.task1/isCoPrime
[Easy] lesson3.task1/squareBetweenExists
[Normal] lesson3.task1/revert
[Normal] lesson3.task1/isPalindrome
[Normal] lesson3.task1/hasDifferentDigits
[Hard] lesson3.task1/squareSequenceDigit
[Hard] lesson3.task1/fibSequenceDigit
[Easy] lesson3.task1/fib
[Easy] lesson3.task1/sin
[Easy] lesson3.task1/cos

Seed: 4944206926986033707

lesson4.task1

Author: Stupidman00 [bva1138@yandex.ru]

Owner: Stupidman00 []

Total: 21 / 21

Example: 7 / 7
Easy: 2 / 2
Normal: 7 / 7
Hard: 4 / 4
Impossible: 1 / 1

Succeeded:

[Normal] lesson4.task1/convert
[Easy] lesson4.task1/mean
[Example] lesson4.task1/sqRoots
[Example] lesson4.task1/invertPositives
[Example] lesson4.task1/negativeList
[Example] lesson4.task1/biRoots
[Example] lesson4.task1/squares
[Example] lesson4.task1/buildSumExample
[Normal] lesson4.task1/center
[Example] lesson4.task1/isPalindrome
[Normal] lesson4.task1/times
[Normal] lesson4.task1/polynom
[Normal] lesson4.task1/accumulate
[Normal] lesson4.task1/factorize
[Hard] lesson4.task1/factorizeToString
[Hard] lesson4.task1/convertToString
[Normal] lesson4.task1/decimal
[Hard] lesson4.task1/decimalFromString
[Hard] lesson4.task1/roman
[Impossible] lesson4.task1/russian
[Easy] lesson4.task1/abs

Seed: 4944206926986033707

owner

Stupidman00 []

mglukhikh

В целом, всё очень хорошо. Прошу исправить замечания по стилю.

mglukhikh · 2016-10-25T12:35:02Z

src/lesson4/task1/List.kt

-fun abs(v: List<Double>): Double = TODO()
+fun abs(v: List<Double>): Double {
+    return if (v.isEmpty()) 0.0
+    else Math.sqrt(v.map { it * it }.sum())


Проверка на isEmpty здесь не нужна. Кроме этого, функцию можно было записать в виде expression body: = Math.sqrt(v.map ...).

mglukhikh · 2016-10-25T12:38:08Z

src/lesson4/task1/List.kt

+    var mutN: Int = n
+    do {
+        result = listOf(mutN%base)+ result
+        mutN/=base


Расставьте, пожалуйста, пробелы более аккуратно

mglukhikh · 2016-10-25T12:38:43Z

src/lesson4/task1/List.kt

+        listOf('0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
+                'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'j',
+                'k', 'l', 'm', 'n', 'o', 'p', 'q', 'r', 's', 't',
+                'u', 'v', 'w', 'x', 'y', 'z')


Вместо списков символов лучше использовать строки вроде "01234...", тогда у вас будет поменьше одинарных кавычек.

mglukhikh · 2016-10-25T12:39:52Z

src/lesson4/task1/List.kt

 * Например: 23 = XXIII, 44 = XLIV, 100 = C
 */
-fun roman(n: Int): String = TODO()
+val table: Map<Int,String> =


Map<Int, String>

И, кстати, явное указание типа здесь и для последующих Map вообще не требуется.

mglukhikh · 2016-10-25T12:40:46Z

src/lesson4/task1/List.kt

+            result += i.value
+            mutN -= i.key
+        }
+    }


Здесь лучше писать так:

for ((key, value) in table) { while (mutN >= key) { result += value mutN -= key } }

mglukhikh · 2016-10-25T12:41:58Z

src/lesson4/task1/List.kt

+fun tripletProcessing(triplet: Int,
+                      unitsTable: Map<Int, String>,
+                      diclensionOfTripletWord: List<String> = listOf()): List<String> {
+    var result: MutableList<String> = mutableListOf()


Дело вкуса, но мне var result = mutableListOf<String>() кажется короче

mglukhikh · 2016-10-25T12:43:34Z

src/lesson4/task1/List.kt

+    }
+
+    if (diclensionOfTripletWord.isNotEmpty()) {
+        if (diclensionOfTripletWord.size == 3) {


Мне кажется, при наличии этой проверки проверка на isNotEmpty() избыточно

mglukhikh · 2016-10-25T12:46:12Z

src/lesson4/task1/List.kt

 * Например: n = 100, base = 4 -> 1210, n = 250, base = 14 -> 13c
 */
-fun convertToString(n: Int, base: Int): String = TODO()
+fun <T> List<T>.indexOf(value: T): Int {


Такая функция имеется в стандартной библиотеке

mglukhikh · 2016-10-25T12:46:43Z

src/lesson4/task1/List.kt

+        var result: List<Int> = listOf()
+        while (newN != 1) {
+            result = result + listOf(minDivisor(newN))
+            newN = newN / minDivisor(newN)


Лучше использовать += и /=

kotlin-polytech-bot · 2016-10-25T18:37:03Z

author

Stupidman00 [bva1138@yandex.ru]

lesson4.task1

Author: Stupidman00 [bva1138@yandex.ru]

Owner: Stupidman00 []

Total: 20 / 21

Example: 7 / 7
Easy: 2 / 2
Normal: 7 / 7
Hard: 4 / 4
Impossible: 0 / 1

Succeeded:

[Normal] lesson4.task1/convert
[Example] lesson4.task1/negativeList
[Normal] lesson4.task1/times
[Normal] lesson4.task1/polynom
[Normal] lesson4.task1/accumulate
[Normal] lesson4.task1/factorize
[Example] lesson4.task1/sqRoots
[Example] lesson4.task1/isPalindrome
[Easy] lesson4.task1/mean
[Example] lesson4.task1/invertPositives
[Example] lesson4.task1/biRoots
[Example] lesson4.task1/squares
[Example] lesson4.task1/buildSumExample
[Normal] lesson4.task1/center
[Hard] lesson4.task1/factorizeToString
[Hard] lesson4.task1/convertToString
[Normal] lesson4.task1/decimal
[Hard] lesson4.task1/decimalFromString
[Hard] lesson4.task1/roman
[Easy] lesson4.task1/abs

Failed:

[Impossible] lesson4.task1/russian
- Expected:
  сорок тысяч сто семьдесят шесть
- Actual:
  сорок сто семьдесят шесть
- Inputs:
  - n ->
    40176
- Exception: null

Seed: -1325375092465392529

owner

Stupidman00 []

kotlin-polytech-bot · 2016-10-25T18:59:50Z

author

Stupidman00 [bva1138@yandex.ru]

lesson4.task1

Author: Stupidman00 [bva1138@yandex.ru]

Owner: Stupidman00 []

Total: 21 / 21

Example: 7 / 7
Easy: 2 / 2
Normal: 7 / 7
Hard: 4 / 4
Impossible: 1 / 1

Succeeded:

[Normal] lesson4.task1/convert
[Normal] lesson4.task1/times
[Example] lesson4.task1/biRoots
[Example] lesson4.task1/squares
[Normal] lesson4.task1/accumulate
[Example] lesson4.task1/buildSumExample
[Normal] lesson4.task1/polynom
[Example] lesson4.task1/sqRoots
[Example] lesson4.task1/negativeList
[Example] lesson4.task1/invertPositives
[Example] lesson4.task1/isPalindrome
[Normal] lesson4.task1/center
[Easy] lesson4.task1/mean
[Hard] lesson4.task1/convertToString
[Normal] lesson4.task1/decimal
[Hard] lesson4.task1/decimalFromString
[Hard] lesson4.task1/roman
[Impossible] lesson4.task1/russian
[Normal] lesson4.task1/factorize
[Hard] lesson4.task1/factorizeToString
[Easy] lesson4.task1/abs

Seed: -4710341070528094694

owner

Stupidman00 []

mglukhikh · 2016-10-27T08:39:43Z

Спасибо за исправления, урок 4 принят.

Stupidman00 added 10 commits September 11, 2016 16:01

Task1 and Tests

25d29bc

lesson2 task1

174606a

lesson2 task1

ecaba60

lesson 2 task 1 and 2

fc1ba73

Some changes in Simple, IfElse, Logical, Loop.

29cadbf

Lesson 3 Task 1 Loop. Some corrections.

543a8ee

hasDifferentDigits() corrected.

4f094e9

sin() and cos() improved a bit

cc81dd5

squareSequenceDigit() and fibSequenceDigit() with higher-order functi…

1cd51e0

…on sequenceDigit()

Lesson 4 Task 1

029687a

Lesson 4 Task 1

033c2e4

mglukhikh self-assigned this Oct 25, 2016

mglukhikh suggested changes Oct 25, 2016

View reviewed changes

mglukhikh added the bad style label Oct 25, 2016

Lesson 4 Task 1: some changes have been done.

fe2b3ef

Lesson 4 Task 1: some changes have been done.

ac74890

mglukhikh removed the bad style label Oct 27, 2016

mglukhikh closed this Oct 27, 2016

Lesson 4. Task 1 #184

Lesson 4. Task 1 #184

Uh oh!

Conversation

Stupidman00 commented Oct 24, 2016

Uh oh!

kotlin-polytech-bot commented Oct 24, 2016

author

lesson1.task1

lesson4.task1

owner

Uh oh!

Stupidman00 commented Oct 24, 2016

Uh oh!

mglukhikh commented Oct 25, 2016

Uh oh!

mglukhikh commented Oct 25, 2016

Uh oh!

kotlin-polytech-bot commented Oct 25, 2016

author

lesson1.task1

lesson2.task1

lesson2.task2

lesson3.task1

lesson4.task1

owner

Uh oh!

mglukhikh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kotlin-polytech-bot commented Oct 25, 2016

author

lesson4.task1

owner

Uh oh!

kotlin-polytech-bot commented Oct 25, 2016

author

lesson4.task1

owner

Uh oh!

mglukhikh commented Oct 27, 2016

Uh oh!

Uh oh!