Skip to content

Test for Lesson 1, Task 1 is not comparable with condition of this Task #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

fembiba
Copy link
Contributor

@fembiba fembiba commented Sep 10, 2021

Condition of Task mean, values must be more than 100, but in Test we tested with 100 value.

I suggest fix condition of Task to more than or equals 100

* Пользователь задает целое число, большее 100 (например, 3801).

assertEquals(1, thirdDigit(100))

@ice-phoenix
Copy link
Collaborator

Hi mate, thanks for noticing this bug in the description! Out of curiosity, why did you decide to use the unconventional order of "равно или больше" instead of a more widely used "больше или равно"?

@fembiba
Copy link
Contributor Author

fembiba commented Sep 10, 2021

Hi too! In order to focus on "равно" word. But this is a bad idea. I guess.

@fembiba
Copy link
Contributor Author

fembiba commented Sep 10, 2021

Oki. I'm refactored.

@ice-phoenix
Copy link
Collaborator

Could I ask you to squash the commits in your branch, so that it contains a single commit with the needed changes?

Fixed condition for the task (Lesson 1, task 1)
@fembiba
Copy link
Contributor Author

fembiba commented Sep 10, 2021

Could I ask you to squash the commits in your branch, so that it contains a single commit with the needed changes?

Oks. I did it

@ice-phoenix ice-phoenix merged commit b9ae321 into Kotlin-Polytech:master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants