forked from highfive-devs/highfive
-
Notifications
You must be signed in to change notification settings - Fork 0
Basic RESTVOL support #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vincentmr
wants to merge
14
commits into
main
Choose a base branch
from
fix_file_paths
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A fix for the issue with XTensor you're seeing in "Unit Tests / OSX (macOS-14, 20)" has just been merged: Rebasing should fix the issue. (Please let me know if it didn't.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
The Highly Scalable Data Service (HSDS) is an open source REST-based solution for reading, writing, and sharing data within object-based storage environments. REST VOL is the HDF5 library plug-in that clients can use to connect with HSDS. As the documentation says, REST VOL allows "organizations to easily move their data to the cloud without a large expenditure in re-writing code." That said, several HDF5 features are missing and must be accounted for.
There aren't a lot (or any?) modern and publicly available C++ bindings libraries out there. With this PR, we'd like to bring a minimal level of REST VOL support into HighFive.
Description of the Change:
HIGHFIVE_ENABLE_RESTVOL
to control REST VOL support.HIGHFIVE_USE_RESTVOL
to branch behaviour in the source code.SliceException
class.This allows handling some limitations:
trim_if_rest_vol
.addr
)to_abs_if_rest_vol
which appends/
if using REST VOL.H5Pset_create_intermediate_group
, so we manually create the parent groups recursively._file_obj
, but we might try to pass it around in the future. This breaksgetFile
.hid
of scalar datasets appears corrupted, so we passH5S_ALL
toh5d_write
.H5Ldelete
does not fail if the file doesn't exists.H5Tget_nmembers
We adapted the basic tests and those of Eigen.
RESTVOL_DISABLED
hides tests that might work, but do not in the PR.RESTVOL_UNSUPPORTED
hides tests that test features that are not supported by REST VOL.delete_file_if_exists
wraps aroundstd::remove
which doesn't work with REST VOL.to_abs_if_rest_vol
makes the file paths absolute if REST VOL is active.trim_if_rest_vol
removes null char from strings if REST VOL is active.This tries to keep the original tests as intact as possible. In many places, we cannot call
createDataSet
/write
for std::string since we need to turn them into fixed-length string first. We thus branch withHIGHFIVE_USE_RESTVOL
and use the auto interface.Benefits:
Possible Drawbacks:
getFile
broken.