[PSA] My ModelPatcher Rework/Hooks PR got merged - latest ADE requires updating ComfyUI

[Kosinkadink]

As the title says, you'll need newest ComfyUI (at least commit comfyanonymous/ComfyUI@0ee322e) for latest ADE to work.

The PR enables my code in ADE and ACN to be a lot less hacky, so it will break far less often with further ComfyUI updates.

[schoenid]

Can't install too.

### ComfyUI Version: v0.2.2 | Released on '2024-09-05' -> latest, updated today in Manager.

Traceback (most recent call last):
  File "G:\SD\Packages\ComfyUI\nodes.py", line 1993, in load_custom_node
    module_spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "G:\SD\Packages\ComfyUI\custom_nodes\ComfyUI-AnimateDiff-Evolved\__init__.py", line 4, in <module>
    from .animatediff.model_injection import prepare_dinklink_register_definitions
  File "G:\SD\Packages\ComfyUI\custom_nodes\ComfyUI-AnimateDiff-Evolved\animatediff\model_injection.py", line 17, in <module>
    from comfy.patcher_extension import CallbacksMP, WrappersMP, PatcherInjection
ModuleNotFoundError: No module named 'comfy.patcher_extension'

Cannot import G:\SD\Packages\ComfyUI\custom_nodes\ComfyUI-AnimateDiff-Evolved module for custom nodes: No module named 'comfy.patcher_extension'

[Kosinkadink]

Your ComfyUI is too outdated. The hooks PR got merged in early December, while your ComfyUI version is from September.

Update ComdyUI and your error will go away.

[schoenid]

Did an update today right now.

Console after Restart:

Traceback (most recent call last):
  File "G:\SD\Packages\ComfyUI\nodes.py", line 1993, in load_custom_node
    module_spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "G:\SD\Packages\ComfyUI\custom_nodes\ComfyUI-Advanced-ControlNet\__init__.py", line 1, in <module>
    from .adv_control.nodes import NODE_CLASS_MAPPINGS, NODE_DISPLAY_NAME_MAPPINGS
  File "G:\SD\Packages\ComfyUI\custom_nodes\ComfyUI-Advanced-ControlNet\adv_control\nodes.py", line 3, in <module>
    from .nodes_main import (ControlNetLoaderAdvanced, DiffControlNetLoaderAdvanced,
  File "G:\SD\Packages\ComfyUI\custom_nodes\ComfyUI-Advanced-ControlNet\adv_control\nodes_main.py", line 6, in <module>
    from .control import load_controlnet, convert_to_advanced, is_advanced_controlnet, is_sd3_advanced_controlnet
  File "G:\SD\Packages\ComfyUI\custom_nodes\ComfyUI-Advanced-ControlNet\adv_control\control.py", line 11, in <module>
    from comfy.controlnet import ControlBase, ControlNet, ControlNetSD35, ControlLora, T2IAdapter, StrengthType
ImportError: cannot import name 'ControlNetSD35' from 'comfy.controlnet' (G:\SD\Packages\ComfyUI\comfy\controlnet.py)

Cannot import G:\SD\Packages\ComfyUI\custom_nodes\ComfyUI-Advanced-ControlNet module for custom nodes: cannot import name 'ControlNetSD35' from 'comfy.controlnet' (G:\SD\Packages\ComfyUI\comfy\controlnet.py)
Traceback (most recent call last):
  File "G:\SD\Packages\ComfyUI\nodes.py", line 1993, in load_custom_node
    module_spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "G:\SD\Packages\ComfyUI\custom_nodes\ComfyUI-AnimateDiff-Evolved\__init__.py", line 4, in <module>
    from .animatediff.model_injection import prepare_dinklink_register_definitions
  File "G:\SD\Packages\ComfyUI\custom_nodes\ComfyUI-AnimateDiff-Evolved\animatediff\model_injection.py", line 17, in <module>
    from comfy.patcher_extension import CallbacksMP, WrappersMP, PatcherInjection
ModuleNotFoundError: No module named 'comfy.patcher_extension'

Cannot import G:\SD\Packages\ComfyUI\custom_nodes\ComfyUI-AnimateDiff-Evolved module for custom nodes: No module named 'comfy.patcher_extension'

   0.0 seconds (IMPORT FAILED): G:\SD\Packages\ComfyUI\custom_nodes\ComfyUI-Advanced-ControlNet
   0.0 seconds (IMPORT FAILED): G:\SD\Packages\ComfyUI\custom_nodes\ComfyUI-AnimateDiff-Evolved

[Kosinkadink]

The file your ADE can't find has existed since the beginning of December in ComfyUI. Either your manager is lying to you or you need to reboot ComfyUI for the update to take an effect.

The only possible cause of the error you're getting is your ComfyUI being outdated. In the first message you sent, the log said ### ComfyUI Version: v0.2.2 | Released on '2024-09-05'.

[schoenid]

Ok.

The problem was, the update has been interrupted, because I've used a symbolic link for the output location. And there is no message about, just the message in the manager "ComfyUI has been sucessfully updated", which is not true, because the update has been interrupted ... I found it by observing another command, using pip in the terminal, which gave me a hint "aborted".

Sorry about and thank you for you patience.
Now everything works fine.

So I have to kill the link everytime, I want to do an update, then i can restore it ...

I did a report at:
comfyanonymous/ComfyUI#6224

[biorpg]

Ok.

The problem was, the update has been interrupted, because I've used a symbolic link for the output location. And there is no message about, just the message in the manager "ComfyUI has been sucessfully updated", which is not true, because the update has been interrupted ... I found it by observing another command, using pip in the terminal, which gave me a hint "aborted".

Sorry about and thank you for you patience. Now everything works fine.

So I have to kill the link everytime, I want to do an update, then i can restore it ...

I did a report at: comfyanonymous/ComfyUI#6224

I suggest that when using linked folders, you use 'junctions' and/or 'hardlinks' on Windows, and 'rbind' mount points on Linux. These seem to work seamlessly for most such purposes, while symlinks and links are hit and miss.