Skip to content

Comments

Upgrade Checker#450

Open
Korko wants to merge 1 commit into1.8.x-laravel12from
shift-163242
Open

Upgrade Checker#450
Korko wants to merge 1 commit into1.8.x-laravel12from
shift-163242

Conversation

@Korko
Copy link
Owner

@Korko Korko commented Dec 12, 2025

This pull request contains changes and comments noting incompatible or deprecated code by the Upgrade Checker. You should review each comment and commit changes to the shift-163242 branch before merging.

Many of the potential changes found by this Shift may be automated by running the Laravel Fixer or tasks within the Shift Workbench.

Shift automatically applies the Laravel coding style - which uses the PSR-12 coding style as a base with some minor additions.

You may customize the code style applied by configuring [Pint](https://laravel.com/docs/pint), [PHP CS Fixer](https://github.com/FriendsOfPHP/PHP-CS-Fixer), or [PHP CodeSniffer](https://github.com/squizlabs/PHP_CodeSniffer) for your project root.

For more information on customizing the code style applied by Shift, [watch this short video](https://laravelshift.com/videos/shift-code-style).
@Korko
Copy link
Owner Author

Korko commented Dec 12, 2025

ℹ️ The latest version of Laravel requires PHP version 8.1 or higher. Unless you have a requirement for using a specific version of PHP, you should set your constraint to: "php": "^8.1".

@Korko
Copy link
Owner Author

Korko commented Dec 12, 2025

❌ Your app/Http/Controllers/Controller.php is declared as an abstract class. This class is no longer abstract as of Laravel 5.2.

@Korko
Copy link
Owner Author

Korko commented Dec 12, 2025

❌ Starting in Laravel 5.2, the Input facade is no longer registered by default. Although the Input facade is still available in Laravel 5, it is removed in Laravel 6. As such, Shift recommends using the Request facade or the $request object within Controllers and Middleware. Review the HTTP Requests documentation for more details.

Shift found potential uses of the Input facade in:

  • resources/views/errors/illustrated-layout.blade.php

@Korko
Copy link
Owner Author

Korko commented Dec 12, 2025

❌ Shift found references to fetch(). This has been replaced by pluck().

  • app/Http/Controllers/DearSantaController.php
  • app/Http/Controllers/OrganizerController.php

@Korko
Copy link
Owner Author

Korko commented Dec 12, 2025

⚠️ The following files differed from the default Laravel version. You should compare your file with the latest version and merge any updates.

  • app/Console/Kernel.php
  • app/Exceptions/Handler.php
  • app/Http/Controllers/Controller.php
  • app/Http/Kernel.php
  • bootstrap/app.php
  • phpunit.xml

@Korko
Copy link
Owner Author

Korko commented Dec 12, 2025

❌ The following configuration files differ from the Laravel defaults. If you are modifying configuration values directly, consider using an environment variable instead to keep these files maintainable. You should compare your configuration files against the latest version and merge any updates.

  • config/auth.php
  • config/broadcasting.php
  • config/cache.php
  • config/database.php
  • config/filesystems.php
  • config/hashing.php
  • config/logging.php
  • config/mail.php
  • config/queue.php
  • config/services.php
  • config/session.php
  • config/view.php

@Korko
Copy link
Owner Author

Korko commented Dec 12, 2025

⚠️ Shift detected your application is missing the webpack.mix.js file. Laravel Elixir changed to Laravel Mix in Laravel 5.4 which uses Webpack, instead of Gulp.

@Korko
Copy link
Owner Author

Korko commented Dec 12, 2025

❌ Laravel 10 added PHP type hints to all user-land code included in a new Laravel application. Shift detected these files are missing type hints. Shift recommends adding them to align with the latest Laravel conventions. You may automate this process by running the Laravel Type Hints task within Shift Workbench.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants