Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: add missing AXIS wagon support #494

Merged
merged 3 commits into from
Mar 22, 2025
Merged

Conversation

hibiyasleep
Copy link
Contributor

@telk5093
Copy link
Member

telk5093 commented Mar 1, 2025

Is PPAR the only AXIS cargo that Korean Train Set does not support?
한국 열차 세트가 미지원하는 AXIS 화물이 PPAR 하나 뿐인가요?

@hibiyasleep
Copy link
Contributor Author

Oops I've missed other climates... I'll check them all
오 다른 기후를 생각 못 했네요... 전부 검수해보겠습니다

@hibiyasleep hibiyasleep marked this pull request as draft March 2, 2025 06:09
@hibiyasleep hibiyasleep changed the title Update: add PPAR (AXIS Plastic Parts) support Update: add missing AXIS wagon support Mar 2, 2025
@telk5093
Copy link
Member

telk5093 commented Mar 2, 2025

Please note that you need to add cargos to cargotable block too
화물 추가시 cargotable 블럭에도 추가해야 하니 참고 부탁드립니다 :)
https://github.com/KoreanGRF/KoreanTrainSet/blob/main/ko_train_set.pnml#L28

@hibiyasleep
Copy link
Contributor Author

hibiyasleep commented Mar 2, 2025

Below is what I've fixed; please let me know if there's any errors or suggesstions.
변경 내역을 정리하였습니다. 어색한 게 있다면 수정하겠습니다!

Name Cargo Flags Result (Texture)
aluminia ALO_ CC_BULK, CC_COVERED, CC_POWDERIZED Hopper (IORE)
ammonium_nitrate NHNO CC_BULK, CC_PIECE_GOODS, CC_HAZARDOUS Box, Hopper (LIME)
biomass BIOM CC_BULK Hopper (SCMT)
chromite_ore CHRO CC_BULK Hopper (IORE)
copper_concentrate COCO CC_BULK, CC_COVERED Hopper (CORE)
cranes_and_hoists CRAN CC_PIECE_GOODS, CC_OVERSIZED Stake (ENSP)
flour BAKE CC_BULK, CC_COVERED, CC_POWDERIZED Bulk
furniture FURN CC_PIECE_GOODS Box, Flat
lifting_equipment LFEQ CC_PIECE_GOODS Stake (ENSP)
meat MEAT CC_EXPRESS, CC_REFRIGERATED Flat
nickel NICK CC_PIECE_GOODS Hopper (MNO2)
oil_seeds OLSD CC_BULK, CC_COVERED Hopper (BEAN)
plastic_parts PPAR CC_PIECE_GOODS Box, Flat
rare_metals RAMT CC_PIECE_GOODS Hopper (CORE)
steel_wire_rope SWRP CC_PIECE_GOODS Box, Flat
sugarcane SGCN CC_BULK, CC_NON_POURABLE Hopper (FRUT)
textiles TEXT CC_PIECE_GOODS Box, Flat
tin TIN_ CC_PIECE_GOODS Hopper (GRVL)
tinplate TINP CC_PIECE_GOODS Stake (STEL)
yarn YARN CC_PIECE_GOODS, CC_COVERED Box, Flat

@hibiyasleep
Copy link
Contributor Author

hibiyasleep commented Mar 2, 2025

seems CC_LIQUID detected automatically, I've removed all addition to cargo_allow_refit of tank_car.
CC_LIQUID 플래그는 자동으로 인식되는 듯하여 tank_car의 cargo_allow_refit에서 제외했습니다. (cargotable엔 남겼습니다)

new liquids:

Name Cargo Flags
acetic_acid ACET CC_LIQUID, CC_HAZARDOUS
ethylene C2H4 CC_LIQUID, CC_HAZARDOUS
raw_latex LATX CC_LIQUID
food_additives ENUM CC_LIQUID, CC_PIECE_GOODS
formic_acid FORM CC_LIQUID, CC_HAZARDOUS
hydrochloric_acid HYAC CC_LIQUID, CC_HAZARDOUS
hydrogen H2__ CC_LIQUID, CC_HAZARDOUS
oxygen O2__ CC_LIQUID
methanol MEOH CC_LIQUID, CC_HAZARDOUS
naphtha NAPH CC_LIQUID
phosphoric_acid PHAC CC_LIQUID, CC_HAZARDOUS
propylene C3H6 CC_LIQUID, CC_HAZARDOUS
sulphuric_acid SUAC CC_LIQUID, CC_HAZARDOUS
urea UREA CC_LIQUID, CC_BULK

@hibiyasleep hibiyasleep marked this pull request as ready for review March 2, 2025 07:56
@telk5093
Copy link
Member

일단은 머지한 뒤에 cargotable은 직접 수정하겠습니다.
I'll merge this first, and gonna update cargotable myself.

@telk5093 telk5093 merged commit 78fd462 into KoreanGRF:main Mar 22, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants