fix pl.path can't resolve the path started with ~

[AllenFang]

Base on lunarmodules/luafilesystem#172, seem pl.isfile and pl.isdif will return the wrong result if the path start with "~"

currently I can confirm there's a bug when load cred file:

local credential = require("resty.aws.config").load_credentials_file("~/.aws/credentials", "xxxprofile")

Above I got nil caused by here, however, I am sure my credentials file exist and format is definitely correct. So I raised the lunarmodules/luafilesystem#172 issue. Not sure how and when they fix it but we can safely fix this issue by an absolute path.

[CLAassistant]

All committers have signed the CLA.

[Tieske]

This is not a task for luafilesystem. Penlight can handle this, see https://lunarmodules.github.io/Penlight/libraries/pl.path.html#expanduser

[AllenFang]

thanks @Tieske

what's the solution you will suggest to?

1. use expanduser in every places that use the penlight isfile function (ex: here)
2. only use expanduser for the default config/credential file path value (ex: here)
   • a probably minor drawback is if user want to customize the path, they have to either give absolute path or wrap up the path by expanduser.

my opinion is first one 🙇

[Tieske]

first option seems fine to me

[AllenFang]

@Tieske sorry for late reply, please take a look. thank you 🙇

[Tieske]

lgtm

[windmgc]

@AllenFang Could you sign the CLA and add a changelog entry in the README?

[AllenFang]

okay, will do it soon

[AllenFang]

hi @windmgc @Tieske just sign the CLA. thanks

[tzssangglass]

ping @windmgc