fix(*): fix v4 signing request should correctly canonicalized query table as well #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
windmgc
changed the title
windmgc
force-pushed
the
fix-signing-v4-encode-query-args
branch
from
0a1b8f4 to
60b4b92
Compare
ADD-SP
approved these changes
Aug 17, 2023
ms2008
approved these changes
Aug 17, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR ensures that
canonicalise_query_stringshould always return a URL encoded format query string. Currently whenqueryis a table, the value will not be encoded again. This makes the STS assumeRole not working since assumeRole requires a IAM ARN which contains colon that should be URL encoded. Calling STS assumeRole will return signature not match error without the PR's fix.