Skip to content

fix: request uri build handling of + in template #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tieske merged 1 commit into from
Oct 20, 2022
Merged

fix: request uri build handling of + in template #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,11 @@ Release process:
1. upload using: `VERSION=x.y.z APIKEY=abc... make upload`
1. test installing the rock from LuaRocks

### 1.0.1 (20-Oct-2022)

- fix: for some method incorrect URL is generates because of incorrect handling of "+" in URL template
[#34](https://github.com/Kong/lua-resty-aws/pull/34)

### 1.0.0 (13-Oct-2022)

- fix: `latest` doesn't indicate the most recent service version
Expand Down
2 changes: 1 addition & 1 deletion src/resty/aws/request/build.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ local function build_request(operation, config, params)
-- print(name," = ", param_value, ": ",location, " (", locationName,")")

if location == "uri" then
local place_holder = "{" .. locationName .. "}"
local place_holder = "{" .. locationName .. "%+?}"
request.path = request.path:gsub(place_holder, param_value)

elseif location == "querystring" then
Expand Down