fix(request-build): fix an issue with location uri param with plus #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luacheck Report3 tests 3 ✅ 0s ⏱️ Results for commit 4755d9a. ♻️ This comment has been updated with latest results. |
Water-Melon
approved these changes
Nov 10, 2025
raoxiaoyan
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where a URI location param with a plus sign needs to preserve the path forward slash instead of escaping it.
This PR makes the behavior be aligned with https://github.com/aws/aws-sdk-js/blob/37f6c66bb2d7ad80c1b88d9dc7a35a875a15a731/dist/aws-sdk-core-react-native.js#L3459-L3460