Skip to content

feat: support http_proxy_authorization and https_proxy_authorization … #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oowl merged 2 commits into from
Jul 2, 2025
Merged

feat: support http_proxy_authorization and https_proxy_authorization … #136

oowl merged 2 commits into from
Jul 2, 2025

Conversation

@oowl
Copy link
Member

@oowl oowl commented Jul 2, 2025

…options

@github-actions
Copy link

github-actions bot commented Jul 2, 2025 •
edited
Loading

Luacheck Report

4 tests   4 ✅  0s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 30879c7.

♻️ This comment has been updated with latest results.

hackerchai
hackerchai previously approved these changes Jul 2, 2025
View reviewed changes
@windmgc
Copy link
Member

windmgc commented Jul 2, 2025

LGTM over all. Do we need to define a new configuration var in config.lua?

FYI this may not be a mandatory for us since the AWS CLI only supports basic auth configured in proxy URL https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-proxy.html#cli-configure-proxy-auth

@windmgc windmgc force-pushed the https_proxy_auth branch from 6ad48af to 5dd9e6a Compare July 2, 2025 08:22
@oowl oowl force-pushed the https_proxy_auth branch from 5dd9e6a to 30879c7 Compare July 2, 2025 08:24
@oowl
Copy link
Member Author

oowl commented Jul 2, 2025

LGTM over all. Do we need to define a new configuration var in config.lua?

FYI this may not be a mandatory for us since the AWS CLI only supports basic auth configured in proxy URL https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-proxy.html#cli-configure-proxy-auth

done, add new http_proxy_authorization and https_proxy_authorization in config.lua

@oowl oowl merged commit 7560e47 into main Jul 2, 2025
9 checks passed
@oowl oowl deleted the https_proxy_auth branch July 2, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windmgc windmgc windmgc approved these changes

@Water-Melon Water-Melon Water-Melon approved these changes

@hackerchai hackerchai hackerchai left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@oowl @windmgc @hackerchai @Water-Melon